Conversation
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
commented
Jun 6, 2026
Comment on lines
+168
to
178
| pub fn save(&mut self) -> Result<(), Error> { | ||
| let filepath = self.filepath.as_path(); | ||
| fs::write(filepath, self.parser.file_content.content()) | ||
| .or_raise(|| Error::new(format!("cannot save document {}", filepath.display()))) | ||
| } | ||
|
|
||
| pub fn save_to(&mut self, filepath: impl AsRef<Path>) -> Result<(), Error> { | ||
| let filepath = filepath.as_ref(); | ||
| fs::write(filepath, self.parser.file_content.content()) | ||
| .or_raise(|| Error::new(format!("cannot save document {}", filepath.display()))) | ||
| } |
Member
Author
There was a problem hiding this comment.
Actually we don't need &mut self but &self here. But use &mut for write operation is fine and it's good to distinguish save/save_to.
tisonkun
enabled auto-merge (squash)
June 6, 2026 16:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.