feat(ag-grid-angular-theme): added multi sort styles (#DS-4844)#175
feat(ag-grid-angular-theme): added multi sort styles (#DS-4844)#175artembelik wants to merge 3 commits into
Conversation
|
Visit the preview URL for this PR (updated for commit 6a5c1dc): https://data-grid-next--data-grid-pr-175-iq0bc8w4.web.app (expires Mon, 15 Jun 2026 09:30:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b9d49913f5b5988e9af8690a8b37f16143707448 |
There was a problem hiding this comment.
Pull request overview
Adds theme support for AG Grid multi-sort indicators and updates the dev/e2e setup so screenshot states (multi-sort, pagination, pinned columns, selections) are configured via the GridApi rather than via test-only UI toggles.
Changes:
- Added
_ag-sort-indicator()SCSS mixin to control sort icon sizing and ensure the sort order badge renders after the icon. - Updated Playwright theme/row-actions screenshot tests to configure grid state through
getAgGridApi()(pagination, multi-sort, pinned columns, selection). - Enabled
alwaysMultiSortin dev theme/overview grids to consistently exercise multi-sort UI.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/ag-grid-angular-theme/src/theme.scss | Adds multi-sort indicator styling mixin and wires it into the theme. |
| dev/ag-grid-angular/src/tests/theme.playwright-spec.ts | Configures grid state via GridApi for stable screenshots (pagination, multi-sort, selection). |
| dev/ag-grid-angular/src/tests/theme.ng.ts | Removes test-only UI toggles; sets alwaysMultiSort and simplifies column defs for e2e page. |
| dev/ag-grid-angular/src/tests/row-actions.playwright-spec.ts | Pins columns via GridApi instead of UI toggles for screenshot setup. |
| dev/ag-grid-angular/src/tests/row-actions.ng.ts | Removes test-only UI toggles; simplifies column defs for e2e page. |
| dev/ag-grid-angular/src/overview.ng.ts | Enables alwaysMultiSort on the overview grid. |
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
✅ Snapshots updated! |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
No description provided.