feat(ag-grid-angular-theme): added `KbqAgGridColumnMenu` directive (#DS-3660) by artembelik · Pull Request #167 · koobiq/data-grid

artembelik · 2026-05-20T14:34:45Z

No description provided.

github-actions · 2026-05-20T14:37:24Z

Visit the preview URL for this PR (updated for commit 9ffe361):

https://data-grid-next--data-grid-pr-167-k35b9aef.web.app

_{(expires Sun, 14 Jun 2026 11:23:52 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: b9d49913f5b5988e9af8690a8b37f16143707448}

github-actions · 2026-05-20T14:39:21Z

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

artembelik · 2026-05-20T14:49:32Z

/approve-snapshots

github-actions · 2026-05-20T14:49:56Z

🔄 Updating snapshots.

github-actions · 2026-05-20T14:55:34Z

✅ Snapshots updated!

rmnturov · 2026-05-21T07:00:00Z

Положение кнопки-меню должно быть в углу грида, а не около последней колонки

rmnturov · 2026-05-21T07:46:04Z

колонку с чекбоксами не надо показывать в меню

artembelik · 2026-05-21T09:59:22Z

Положение кнопки-меню должно быть в углу грида, а не около последней колонки

колонку с чекбоксами не надо показывать в меню

@rmnturov поправил

Copilot

Pull request overview

Adds a new AG Grid Angular theme feature to render always-visible “header row actions” as a custom overlay component, plus accompanying styling and dev/e2e coverage. The PR also includes a broad dependency upgrade (Angular + Koobiq ecosystem) and some dev-app wiring changes.

Changes:

Introduces KbqAgGridHeaderRowActions directive + injection token to mount a custom component into the grid header area.
Adds theme SCSS for the header actions overlay and wires the directive into the theme module + public exports.
Extends the dev app with a new “header-actions” page and Playwright spec, plus upgrades dependencies/lint config.

Reviewed changes

Copilot reviewed 37 out of 38 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
packages/ag-grid-angular-theme/src/to-next-row-by-tab.ng.ts	Reorders directive metadata fields.
packages/ag-grid-angular-theme/src/theme.scss	Adds header actions overlay styling mixin and includes it in the theme.
packages/ag-grid-angular-theme/src/theme.ng.ts	Reorders directive metadata fields.
packages/ag-grid-angular-theme/src/status-bar.ng.ts	Reorders directive metadata fields.
packages/ag-grid-angular-theme/src/select-rows-by-shift-click.ng.ts	Reorders directive metadata fields.
packages/ag-grid-angular-theme/src/select-rows-by-shift-arrow.ng.ts	Reorders directive metadata fields.
packages/ag-grid-angular-theme/src/select-rows-by-ctrl-click.ng.ts	Reorders directive metadata fields.
packages/ag-grid-angular-theme/src/select-all-rows-by-ctrl-a.ng.ts	Reorders directive metadata fields.
packages/ag-grid-angular-theme/src/row-actions.ng.ts	Reorders directive metadata fields.
packages/ag-grid-angular-theme/src/quick-filter-state.ng.ts	Reorders directive metadata fields.
packages/ag-grid-angular-theme/src/module.ng.ts	Registers the new header actions directive in the theme module.
packages/ag-grid-angular-theme/src/header-row-actions.ng.ts	New directive + injection token to render header overlay component.
packages/ag-grid-angular-theme/src/filter-state.ng.ts	Reorders directive metadata fields.
packages/ag-grid-angular-theme/src/external-filter-state.ng.ts	Reorders directive metadata fields.
packages/ag-grid-angular-theme/src/copy-by-ctrl-c.ng.ts	Reorders directive metadata fields.
packages/ag-grid-angular-theme/src/column-state.ng.ts	Reorders directive metadata fields.
packages/ag-grid-angular-theme/index.ts	Exports the new header actions directive publicly.
package.json	Upgrades Angular/Koobiq/tooling dependencies.
dev/ag-grid-angular/src/tests/to-next-row-by-tab.ng.ts	Reorders component metadata fields in dev test page.
dev/ag-grid-angular/src/tests/theme.ng.ts	Reorders component metadata fields in dev test page.
dev/ag-grid-angular/src/tests/status-bar.ng.ts	Reorders component metadata fields in dev test page.
dev/ag-grid-angular/src/tests/select-rows-by-shift-click.ng.ts	Reorders component metadata fields in dev test page.
dev/ag-grid-angular/src/tests/select-rows-by-shift-arrow.ng.ts	Reorders component metadata fields in dev test page.
dev/ag-grid-angular/src/tests/select-rows-by-ctrl-click.ng.ts	Reorders component metadata fields in dev test page.
dev/ag-grid-angular/src/tests/row-actions.ng.ts	Reorders component metadata fields in dev test page.
dev/ag-grid-angular/src/tests/quick-filter-state.ng.ts	Reorders component metadata fields in dev test page.
dev/ag-grid-angular/src/tests/header-actions.playwright-spec.ts	New Playwright coverage for header actions interactions (visibility/order/drag).
dev/ag-grid-angular/src/tests/header-actions.ng.ts	New dev page demonstrating header actions component behavior.
dev/ag-grid-angular/src/tests/filter-state.ng.ts	Reorders component metadata fields in dev test page.
dev/ag-grid-angular/src/tests/external-filter-state.ng.ts	Reorders component metadata fields in dev test page.
dev/ag-grid-angular/src/tests/copy-by-ctrl-c.ng.ts	Reorders component metadata fields in dev test page.
dev/ag-grid-angular/src/tests/column-state.ng.ts	Reorders component metadata fields in dev test page.
dev/ag-grid-angular/src/styles.scss	Adds Koobiq prebuilt theme stylesheet import for the dev app.
dev/ag-grid-angular/src/overview.ng.ts	Updates dev overview UI and adds header actions demo + new UI controls/UX changes.
dev/ag-grid-angular/src/main.ts	Adds route for header-actions page and enables animations provider.
dev/ag-grid-angular/src/app.ng.ts	Reorders component metadata fields.
.eslintrc.js	Disables two Angular template accessibility lint rules.

github-actions · 2026-05-29T08:57:55Z

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

github-actions · 2026-05-29T09:23:46Z

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

github-actions · 2026-05-29T13:03:32Z

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

github-actions · 2026-06-01T14:06:51Z

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

artembelik · 2026-06-01T14:07:24Z

/approve-snapshots

github-actions · 2026-06-01T14:07:38Z

🔄 Updating snapshots.

github-actions · 2026-06-01T14:10:19Z

✅ Snapshots updated!

Copilot

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 4 comments.

github-actions · 2026-06-08T14:14:18Z

🔄 Updating snapshots.

github-actions · 2026-06-08T14:16:32Z

✅ Snapshots updated!

github-actions · 2026-06-09T08:54:26Z

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

artembelik · 2026-06-09T09:45:54Z

Прыгает скролл и увеличивается высота страницы

поправил

artembelik · 2026-06-09T09:47:26Z

Давай скроллбар JS-сный сделаем, чтобы появлялся по ховеру или скроллу и располагался поверх. Это минор

реализовал при помощи css

github-actions · 2026-06-09T09:53:39Z

🚨 E2E tests failed

Review the report for details.

💡 Comment /approve-snapshots to approve snapshot changes.

artembelik · 2026-06-09T10:05:30Z

/approve-snapshots

github-actions · 2026-06-09T10:05:42Z

🔄 Updating snapshots.

github-actions · 2026-06-09T10:08:35Z

✅ Snapshots updated!

artembelik · 2026-06-09T11:29:50Z

Драг-н-дроп надо анимировать. Например, чуть начали тащить, отпускаем и элемент плавно возвращается на прежнее место. Вроде как .cdk-drag-animating

добавил

artembelik self-assigned this May 20, 2026

artembelik marked this pull request as ready for review May 21, 2026 09:58

artembelik requested review from NikGurev and lskramarov as code owners May 21, 2026 09:58

Copilot AI review requested due to automatic review settings May 21, 2026 09:58

Copilot started reviewing on behalf of artembelik May 21, 2026 09:58 View session

artembelik requested a review from rmnturov May 21, 2026 09:58

Copilot AI reviewed May 21, 2026

View reviewed changes

artembelik marked this pull request as draft May 22, 2026 08:51

artembelik force-pushed the feat/DS-3660 branch from 541b312 to c13a9a8 Compare May 29, 2026 08:54

artembelik changed the title ~~feat(ag-grid-angular-theme): added KbqAgGridHeaderRowActions directive (#DS-3660)~~ feat(ag-grid-angular-theme): added KbqAgGridColumnMenu directive (#DS-3660) May 29, 2026

artembelik marked this pull request as ready for review June 1, 2026 14:07

artembelik requested a review from Copilot June 1, 2026 14:07

Copilot started reviewing on behalf of artembelik June 1, 2026 14:08 View session

Copilot AI reviewed Jun 1, 2026

View reviewed changes

Comment thread packages/ag-grid-angular-theme/src/column-menu.ng.ts

Comment thread packages/ag-grid-angular-theme/src/column-menu.ng.ts

Comment thread packages/ag-grid-angular-theme/src/column-menu.ng.ts Outdated

Comment thread .eslintrc.js

artembelik and others added 16 commits June 9, 2026 12:49

refactor: column menu

b9ee780

refactor: unit

08a8bae

refactor: key manager

dd35d11

refactor: selection

cd1f33c

refactor: menu position

f642986

test: updated e2e snapshots

4a044cc

refactor: lockVisible

5ce4fe4

refactor: review

7b24089

refactor: e2e

d2c1cfb

test: updated e2e snapshots

7ceacc0

refactor: ci

f55def6

refactor: design review

efffb7f

test: updated e2e snapshots

3772557

refactor: scrollbar

30588a1

refactor: styles

5da5ab4

refactor: max-height

6f89c1e

artembelik force-pushed the feat/DS-3660 branch from c37bcad to 6f89c1e Compare June 9, 2026 09:50

test: updated e2e snapshots

15793a0

artembelik added 2 commits June 9, 2026 14:21

refactor: dnd animations

9adb346

refactor: list animations

9ffe361

Conversation

artembelik commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 20, 2026

🚨 E2E tests failed

Uh oh!

artembelik commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026

Uh oh!

rmnturov commented May 21, 2026

Uh oh!

rmnturov commented May 21, 2026

Uh oh!

artembelik commented May 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 29, 2026

🚨 E2E tests failed

Uh oh!

github-actions Bot commented May 29, 2026

🚨 E2E tests failed

Uh oh!

github-actions Bot commented May 29, 2026

🚨 E2E tests failed

Uh oh!

github-actions Bot commented Jun 1, 2026

🚨 E2E tests failed

Uh oh!

artembelik commented Jun 1, 2026

Uh oh!

github-actions Bot commented Jun 1, 2026

Uh oh!

github-actions Bot commented Jun 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 8, 2026

Uh oh!

github-actions Bot commented Jun 8, 2026

Uh oh!

github-actions Bot commented Jun 9, 2026

🚨 E2E tests failed

Uh oh!

artembelik commented Jun 9, 2026

Uh oh!

artembelik commented Jun 9, 2026

Uh oh!

github-actions Bot commented Jun 9, 2026

🚨 E2E tests failed

Uh oh!

artembelik commented Jun 9, 2026

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

github-actions Bot commented May 20, 2026 •

edited

Loading