feat(tree): add selectable input to KbqTreeOption (#DS-4276)#1629
Open
lskramarov wants to merge 3 commits into
Open
feat(tree): add selectable input to KbqTreeOption (#DS-4276)#1629lskramarov wants to merge 3 commits into
lskramarov wants to merge 3 commits into
Conversation
artembelik
approved these changes
Jun 10, 2026
|
Visit the preview URL for this PR (updated for commit 7da0013): https://koobiq-next--prs-1629-3tmdqiha.web.app (expires Mon, 15 Jun 2026 15:49:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new selectable input for KbqTreeOption to allow disabling user-driven selection (click/keyboard/select-all) while keeping options focusable/navigable/expandable, and includes related fixes for option action button integration with dropdown/tooltip triggers.
Changes:
- Add
selectableinput toKbqTreeOptionand update tree selection logic to respect it across click, keyboard, range selection, and select-all. - Fix
KbqOptionActionComponentintegration by keeping tooltip/dropdown triggers as decorator@ContentChildqueries (not signal queries) and restoringdropdownClosedas anEventEmitter. - Add/extend unit tests and update tree examples/docs to describe the new
selectablebehavior.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/public_api_guard/components/tree.api.md | Updates extracted public API for KbqTreeOption queries and selectable input. |
| tools/public_api_guard/components/list.api.md | Updates extracted public API for KbqListOption queries after switching trigger queries back to decorator-based. |
| tools/public_api_guard/components/dropdown.api.md | Updates extracted public API for KbqDropdownTrigger.dropdownClosed type change. |
| packages/components/tree/tree-selection.component.ts | Enforces selectable across selection paths (click, keyboard auto-select, range selection, select all). |
| packages/components/tree/tree-selection.component.spec.ts | Adds coverage for non-selectable behavior and regression coverage for action button + dropdown rendering. |
| packages/components/tree/tree-option.component.ts | Adds selectable input and switches tooltip/dropdown trigger queries to decorator @ContentChild for option-action compatibility. |
| packages/components/tree/examples.tree.ru.md | Documents selectable behavior in Russian examples. |
| packages/components/tree/examples.tree.en.md | Documents selectable behavior in English examples. |
| packages/components/list/list-selection.component.ts | Switches tooltip/dropdown trigger queries to decorator @ContentChild for option-action compatibility. |
| packages/components/dropdown/dropdown-trigger.directive.ts | Keeps dropdownClosed as @Output() EventEmitter<void> so option-action can subscribe via .pipe(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.