fix(docs): scroll to anchor (#DS-4338)#1628
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 84bfcc0): https://koobiq-next--prs-1628-k8wfmiyl.web.app (expires Mon, 15 Jun 2026 08:51:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the docs app’s anchor scrolling behavior so fragment navigation reliably scrolls to the correct section even when lazily-loaded live examples/components render after initial navigation.
Changes:
- Ensure live example dynamic imports are tracked within Angular’s zone to avoid premature “stable” events.
- Rework anchors logic to scroll to the fragment target and attempt to correct post-render layout shifts.
- Simplify anchor offset/active-link calculations by computing positions dynamically.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/docs/src/app/components/live-example-viewer/docs-live-example-viewer.ts | Runs dynamic example loading inside NgZone to better synchronize with ngZone.onStable-based scroll timing. |
| apps/docs/src/app/components/anchors/anchors.component.ts | Refactors fragment scrolling and active-anchor detection; adds resize-based re-scroll attempt for lazy content shifts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lskramarov
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.