🐛 Fix flaky hub validation of synthesized discovery rulesets; run unit tests in CI

[fabianvf]

Summary

Fixes the race reported by @mguetta1 where hub-target tests fail with Unexpected ruleset found: technology-usage depending on discovery-task timing (nerd-dinner, locally flaky while nightly stays green).

Root cause: the tackle-hub target synthesizes discovery-rules/technology-usage rulesets from the hub's discovery-task tags (no kantra equivalent, and tag contents are never compared for the hub target). koncur only waits on the analysis task, and empty rulesets are filtered before validation — so if tech-discovery finishes before the tag snapshot the synthesized ruleset survives with tags and trips the shared unexpected-ruleset check; if not, it's filtered and the test passes. Only C# is affected because the kantra-generated expected output for nerd-dinner has no technology-usage ruleset (all Java expected outputs do).

Fix: the unexpected-ruleset check now skips discovery-rules/technology-usage for tackle-hub when the ruleset contains nothing but tags. Rulesets with real content (violations/insights/errors) still fail, and the missing-ruleset direction is unchanged. Historical hub outputs show insight reporting for tagging rules has varied across hub versions, so tolerating the fabricated tag-only ruleset is the only behavior correct under all observed variants (as opposed to dropping the tag collection, which would break Java tests on hubs that don't report tagging insights).

Also: unit tests now run in CI

While verifying, we found no CI job runs go test — the unit tests in pkg/config and pkg/targets have been uncompilable since the CustomRule refactor (#44, ~4 months) without anyone noticing.

• Updated rule-handling tests to the CustomRule model; rewrote prepareRules/prepareRulesForHub tests to exercise the real methods (including the hub's one-git-repo and no-mixed-rules error paths) instead of simulating removed logic
• TestNewTackleHubTarget now stubs the login probe with httptest instead of retrying against localhost:8080 for 3 minutes
• New unit-tests job (go vet ./... + go test ./...) in the PR CI workflow

Test plan

• go vet ./... clean
• go test ./... green (pkg/targets down from 180s of network retries to <1s)
• New TestValidateFiles_HubSynthesizedDiscoveryRulesets covers the exact failure shape: tag-only technology-usage absent from expected passes for tackle-hub, still fails for kantra, and a synthesized-name ruleset with insights still fails
• Hub nightly on this branch (validator change only relaxes the one fabricated-data check, so Java tests are unaffected by construction)

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of discovered rulesets so tag-only synthesized rulesets are accepted for hub-based validation, while real content still triggers validation errors.
  • Made rule URL and path parsing more reliable for both Git-based and local file rules.

• Tests

  • Expanded coverage for ruleset validation and rule parsing across hub and Kantra scenarios.

[coderabbitai]

📝 Walkthrough

Walkthrough

Test suites across pkg/config, pkg/targets, and pkg/validator are refactored to use structured config.CustomRule/GitRepoRule types instead of string-based analysis.Rules. validator.go adds logic to skip synthesized tag-only rulesets for tackle-hub targets. A new CI job runs go vet and go test.

Changes

CustomRule refactor, hub validation, and CI unit tests

Layer / File(s)	Summary
GitRepoRule parsing tests pkg/config/git_url_test.go	Re-scopes ParseGitURLs test table to application-only cases and adds TestGitRepoRule_GetCompents validating GitRepoRule component extraction.
Kantra rule preparation tests pkg/targets/kantra_test.go	Reworks PrepareRules and GitURLIntegration tests to use config.CustomRule and call prepareRules/GetCompents directly, removing unused fmt import.
TackleHub target and rule prep tests pkg/targets/tackle_hub_test.go	Uses httptest server with dynamic URL in place of hard-coded localhost, and refactors PrepareRulesForHub/GitURLIntegration tests to use config.CustomRule and inspect taskData.Rules directly.
Synthesized ruleset validation pkg/validator/validator.go, pkg/validator/validator_test.go	Adds isSynthesizedTagRuleset helper and skips unexpected tag-only discovery-rules/technology-usage rulesets for tackle-hub targets in ValidateFiles, with new coverage test.
CI unit test job .github/workflows/ci.yaml	Adds a unit-tests job running go vet and go test with Go 1.25.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

• konveyor/koncur#25: Refactors tackle_hub_test.go to use structured config.CustomRule/Git components and asserts prepareRulesForHub outputs, targeting the same hub rule/Git preparation behavior.
• konveyor/koncur#44: Builds on the config.CustomRule/GitRepoRule.GetCompents() refactor and prior validator.go tackle-hub ruleset handling, modifying the same git-rule parsing and validator code paths.

Suggested reviewers: jmle, shawn-hurley

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the two main changes: fixing hub validation for synthesized discovery rulesets and adding unit tests to CI.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[fabianvf]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yaml:
- Around line 10-25: The unit-tests workflow job is using overly broad default
permissions and is persisting the checkout token in git config. Update the
unit-tests job in the ci workflow to add a permissions block limited to
contents: read, and configure the actions/checkout step to disable credential
persistence with persist-credentials set to false. Use the unit-tests job and
the checkout step as the points to locate the change.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bbd4a684-3879-4e18-942e-8cd67bb80f9e

📥 Commits

Reviewing files that changed from the base of the PR and between ed0c1d3 and fc32f81.

📒 Files selected for processing (6)

• .github/workflows/ci.yaml
• pkg/config/git_url_test.go
• pkg/targets/kantra_test.go
• pkg/targets/tackle_hub_test.go
• pkg/validator/validator.go
• pkg/validator/validator_test.go

[konveyor-ci-bot]

PR cherry-picked to branch release-0.10. Backport PR: #102