Pin podman-cli to v5.8.1 on Windows#96
Conversation
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
📝 WalkthroughWalkthroughTwo GitHub Actions workflow files were modified to pin the ChangesPodman Version Pin
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/kantra-local.yaml (1)
45-46: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider tracking the pin removal.
Both workflows now hardcode
podman-cli@5.8.1as a workaround. Since it's duplicated across two files, consider adding a linked issue reference (or a TODO with issue URL) in the comment so the pin is removed from both places once upstream Podman fixes the Windows 6.0 SSH regression.Also applies to: 65-66
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/kantra-local.yaml around lines 45 - 46, The Podman CLI version pin is duplicated as a temporary workaround, so add a clear TODO or linked issue reference alongside the podman-cli@5.8.1 usage in the workflow step to track its removal later. Update the relevant workflow entry that runs the Podman commands so the comment points to the upstream Windows 6.0 SSH regression fix, making it obvious this pin should be removed from both workflow copies once the issue is resolved.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/kantra-local.yaml:
- Around line 45-46: The Podman CLI version pin is duplicated as a temporary
workaround, so add a clear TODO or linked issue reference alongside the
podman-cli@5.8.1 usage in the workflow step to track its removal later. Update
the relevant workflow entry that runs the Podman commands so the comment points
to the upstream Windows 6.0 SSH regression fix, making it obvious this pin
should be removed from both workflow copies once the issue is resolved.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3b24e45d-9956-4d7c-8af7-f36d843a50d6
📒 Files selected for processing (2)
.github/workflows/kantra-local.yaml.github/workflows/kantra.yaml
|
The premerge CI Windows failures are expected - they will resolve once this PR is merged. Why: The So the premerge workflow is still using the unpinned The regular CI workflow ( |
|
Failed to cherry-pick this PR to branch release-0.9. View failed action |
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Cherry-pick PR: #94 |
* Fix analysisMode in few tests * Pin podman-cli to v5.8.1 on Windows (#96) --------- Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Summary by CodeRabbit