Skip to content

Pin podman-cli to v5.8.1 on Windows#96

Merged
mguetta1 merged 2 commits into
konveyor:mainfrom
mguetta1:windows-run
Jul 7, 2026
Merged

Pin podman-cli to v5.8.1 on Windows#96
mguetta1 merged 2 commits into
konveyor:mainfrom
mguetta1:windows-run

Conversation

@mguetta1

@mguetta1 mguetta1 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved Windows workflow reliability by pinning a Podman CLI version, helping avoid SSH connection failures during setup.

Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1 mguetta1 added the cherry-pick/release-0.9 This PR should be cherry-picked to release-0.9 branch label Jul 6, 2026
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Two GitHub Actions workflow files were modified to pin the podman-cli package to version 5.8.1 during Windows kantra installation steps, replacing the previous unversioned install, with an accompanying comment noting the reason for the pin.

Changes

Podman Version Pin

Layer / File(s) Summary
Pin podman-cli to 5.8.1
.github/workflows/kantra.yaml, .github/workflows/kantra-local.yaml
Windows install steps now use choco install podman-cli --version=5.8.1 instead of installing the latest version, with a comment explaining the pin avoids SSH connection failures with Podman 6.0 on Windows.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the main change: pinning podman-cli to v5.8.1 on Windows.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/kantra-local.yaml (1)

45-46: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider tracking the pin removal.

Both workflows now hardcode podman-cli@5.8.1 as a workaround. Since it's duplicated across two files, consider adding a linked issue reference (or a TODO with issue URL) in the comment so the pin is removed from both places once upstream Podman fixes the Windows 6.0 SSH regression.

Also applies to: 65-66

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/kantra-local.yaml around lines 45 - 46, The Podman CLI
version pin is duplicated as a temporary workaround, so add a clear TODO or
linked issue reference alongside the podman-cli@5.8.1 usage in the workflow step
to track its removal later. Update the relevant workflow entry that runs the
Podman commands so the comment points to the upstream Windows 6.0 SSH regression
fix, making it obvious this pin should be removed from both workflow copies once
the issue is resolved.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/kantra-local.yaml:
- Around line 45-46: The Podman CLI version pin is duplicated as a temporary
workaround, so add a clear TODO or linked issue reference alongside the
podman-cli@5.8.1 usage in the workflow step to track its removal later. Update
the relevant workflow entry that runs the Podman commands so the comment points
to the upstream Windows 6.0 SSH regression fix, making it obvious this pin
should be removed from both workflow copies once the issue is resolved.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3b24e45d-9956-4d7c-8af7-f36d843a50d6

📥 Commits

Reviewing files that changed from the base of the PR and between 58175af and 186bef7.

📒 Files selected for processing (2)
  • .github/workflows/kantra-local.yaml
  • .github/workflows/kantra.yaml

@mguetta1
mguetta1 enabled auto-merge (squash) July 6, 2026 10:10
@mguetta1
mguetta1 disabled auto-merge July 6, 2026 10:14
@mguetta1

mguetta1 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

The premerge CI Windows failures are expected - they will resolve once this PR is merged.

Why: The pull_request_target trigger in permerge-ci.yaml resolves reusable workflows (like kantra-local.yaml) from the base branch (main), not the PR branch. You can see this in the logs:

Uses: konveyor/koncur/.github/workflows/kantra-local.yaml@refs/heads/main

So the premerge workflow is still using the unpinned choco install podman-cli from main, which installs v6.0.0 and fails with:

Error: unable to connect to Podman socket: ssh: rejected: connect failed (open failed)

The regular CI workflow (ci.yaml) uses pull_request events where reusable workflows resolve from the PR branch, so it picks up the v5.8.1 pin and passes.

@mguetta1
mguetta1 requested review from ibragins and jmle July 6, 2026 10:50
@mguetta1 mguetta1 closed this Jul 6, 2026
@mguetta1 mguetta1 reopened this Jul 6, 2026
@mguetta1
mguetta1 merged commit ed0c1d3 into konveyor:main Jul 7, 2026
8 checks passed
@mguetta1
mguetta1 deleted the windows-run branch July 7, 2026 07:08
@konveyor-ci-bot

Copy link
Copy Markdown

Failed to cherry-pick this PR to branch release-0.9. View failed action

mguetta1 added a commit to mguetta1/koncur that referenced this pull request Jul 7, 2026
Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
@mguetta1

mguetta1 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Failed to cherry-pick this PR to branch release-0.9. View failed action

Cherry-pick PR: #94

mguetta1 added a commit that referenced this pull request Jul 7, 2026
* Fix analysisMode in few tests

* Pin podman-cli to v5.8.1 on Windows (#96)

---------

Signed-off-by: Maayan Hadasi <mguetta@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/release-0.9 This PR should be cherry-picked to release-0.9 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants