Skip to content

🐛 adding back OpenMRS to test with updates to kantra to enable local-m2…#70

Open
shawn-hurley wants to merge 3 commits into
konveyor:mainfrom
shawn-hurley:add-back-windows-test-failing
Open

🐛 adding back OpenMRS to test with updates to kantra to enable local-m2…#70
shawn-hurley wants to merge 3 commits into
konveyor:mainfrom
shawn-hurley:add-back-windows-test-failing

Conversation

@shawn-hurley

@shawn-hurley shawn-hurley commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

…-dir

Summary by CodeRabbit

  • Tests

    • Reordered logLevel entries in multiple test configs (no behavioral change).
    • Adjusted one test's target indentation affecting .NET target shape.
    • Updated expected-output descriptions and some expected Maven-cache paths.
    • Tweaked a test rule entry to include an explicit git field.
  • Bug Fixes

    • Canonicalized additional Maven repository path variants for consistent handling.
  • Chores

    • Updated Windows Kantra download/source used by CI for installing the Kantra executable.

…-dir

Signed-off-by: Shawn Hurley <shawn@hurley.page>
@coderabbitai

coderabbitai Bot commented Apr 27, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 51945970-5c4c-4df7-9794-e16aaedb69d0

📥 Commits

Reviewing files that changed from the base of the PR and between 9fba73b and 6f361bc.

📒 Files selected for processing (14)
  • pkg/parser/parser.go
  • tests/acmeair-webapp/test.yaml
  • tests/book-server-deps/test.yaml
  • tests/coolstore-source-and-dependencies/test.yaml
  • tests/daytrader/test.yaml
  • tests/nerd-dinner/test.yaml
  • tests/openmrs/test.yaml
  • tests/python-sample/expected-output.yaml
  • tests/python-sample/test.yaml
  • tests/seam-booking/test.yaml
  • tests/tackle-testapp-with-custom-rules/test.yaml
  • tests/tackle-testapp-with-deps/expected-output.yaml
  • tests/tackle-testapp-with-deps/test.yaml
  • tests/tomcat-legacy/test.yaml
✅ Files skipped from review due to trivial changes (12)
  • tests/seam-booking/test.yaml
  • tests/book-server-deps/test.yaml
  • tests/acmeair-webapp/test.yaml
  • tests/tackle-testapp-with-custom-rules/test.yaml
  • tests/daytrader/test.yaml
  • pkg/parser/parser.go
  • tests/python-sample/expected-output.yaml
  • tests/tackle-testapp-with-deps/test.yaml
  • tests/coolstore-source-and-dependencies/test.yaml
  • tests/openmrs/test.yaml
  • tests/tomcat-legacy/test.yaml
  • tests/tackle-testapp-with-deps/expected-output.yaml

📝 Walkthrough

Walkthrough

Reorders and small edits across many test YAMLs (mostly moving analysis.logLevel), updates expected-output paths in one test, adds git: null and rule structure tweak in a Python test, adjusts Maven path normalization in parser code, and changes the Windows Kantra image reference in CI.

Changes

Cohort / File(s) Summary
CI Workflow
.github/workflows/kantra.yaml
Windows Kantra download image changed from quay.io/konveyor/kantra:latest to quay.io/shawn_hurley/kantra:testing-image; Windows step logic unchanged.
Path normalization code
pkg/parser/parser.go
Extend path normalization to canonicalize Maven cache paths under /opt/input/maven-cache/repository/ to /m2/.
Test YAMLs — logLevel reorders
tests/openmrs/test.yaml, tests/acmeair-webapp/test.yaml, tests/book-server-deps/test.yaml, tests/coolstore-source-and-dependencies/test.yaml, tests/daytrader/test.yaml, tests/seam-booking/test.yaml, tests/tackle-testapp-with-deps/test.yaml, tests/tomcat-legacy/test.yaml, tests/tackle-testapp-with-custom-rules/test.yaml
Repositioned analysis.logLevel: 9 within the analysis mappings; no value or behavioral changes.
Test YAML — structural/field edits
tests/nerd-dinner/test.yaml, tests/python-sample/test.yaml
nerd-dinner: changed indentation/shape of analysis.target so dotnet-core is nested differently. python-sample: added git: null and adjusted analysis.rules list/indentation for rule-example.yaml.
Expected output updates
tests/python-sample/expected-output.yaml, tests/tackle-testapp-with-deps/expected-output.yaml
python-sample: populated description for two violations. tackle-testapp-with-deps: updated three variables.file Maven paths from file:///addon/.m2/... to file:///opt/input/maven-cache/....

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I nibble lines and hop through code, 🐇
Moving keys where they bestly bode.
A path rewritten, a CI image swapped,
Tiny edits — the rabbit hopped.
Patches stitched, the tests applaud.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: restoring OpenMRS tests and updating kantra to handle local Maven cache paths (changing from /addon/.m2/ to /opt/input/maven-cache/).
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@shawn-hurley

Copy link
Copy Markdown
Collaborator Author

/ci test-with #70

Signed-off-by: Shawn Hurley <shawn@hurley.page>
Signed-off-by: Shawn Hurley <shawn@hurley.page>
@shawn-hurley
shawn-hurley enabled auto-merge (squash) April 30, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant