Skip to content

Update nerd dinner output after removing Java rulesets#101

Open
eemcmullan wants to merge 1 commit into
konveyor:mainfrom
eemcmullan:nerd-dinner
Open

Update nerd dinner output after removing Java rulesets#101
eemcmullan wants to merge 1 commit into
konveyor:mainfrom
eemcmullan:nerd-dinner

Conversation

@eemcmullan

@eemcmullan eemcmullan commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Relevant kantra PR: konveyor/kantra#866

Summary by CodeRabbit

  • Tests
    • Updated expected test output by removing obsolete discovery-rules results and associated incident data.

Signed-off-by: Emily McMullan <emcmulla@redhat.com>
@eemcmullan eemcmullan added the cherry-pick/release-0.10 This PR should be cherry-picked to release-0.10 branch label Jul 17, 2026
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2ca3affa-7c23-4765-be8a-8dc7c2c1a797

📥 Commits

Reviewing files that changed from the base of the PR and between ed0c1d3 and 9669bb9.

📒 Files selected for processing (1)
  • tests/nerd-dinner/expected-output.yaml
💤 Files with no reviewable changes (1)
  • tests/nerd-dinner/expected-output.yaml

📝 Walkthrough

Walkthrough

The nerd-dinner expected output fixture no longer includes the discovery-rules ruleset, its BSD License insight, incident data, or unmatched rule IDs.

Changes

Cohort / File(s) Summary
Expected output fixture
tests/nerd-dinner/expected-output.yaml
Removes the complete discovery-rules section from the expected YAML output.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • konveyor/koncur#58: Adds the discovery-rules section that this PR removes from the fixture.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: updating Nerd Dinner output after removing Java rulesets.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eemcmullan
eemcmullan requested review from jmle and mguetta1 July 17, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/release-0.10 This PR should be cherry-picked to release-0.10 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants