🐛 Fixes Respect Keyboard interrupt #776#777
Conversation
Signed-off-by: John Matthews <jwmatthews@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…sing Signed-off-by: John Matthews <jwmatthews@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: John Matthews <jwmatthews@gmail.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…Chan send instead of buffered channel Signed-off-by: John Matthews <jwmatthews@gmail.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
==========================================
- Coverage 49.93% 49.67% -0.26%
==========================================
Files 53 53
Lines 4474 4497 +23
==========================================
Hits 2234 2234
- Misses 1966 1989 +23
Partials 274 274 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The previous implementation listened on ctx.Done() which also fires on normal shutdown via deferred stop(), causing misleading "Interrupt received" output and leaked signal state on clean exits. Use a dedicated signal.Notify channel so the message only prints on a real SIGINT, and an analysisDone channel so the goroutine exits cleanly on normal shutdown. Signed-off-by: John Matthews <jwmatthews@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. |
Fix Ctrl-C lockup during analysis (#776)
kantra analyze hangs when Ctrl-C is pressed during rule processing,
provider startup, or provider preparation. Multiple independent bugs
prevent signal context cancellation from propagating to blocking
operations.
analyzer-lsp fixes:
kantra fixes:
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
fixes #776
Dependent on konveyor/analyzer-lsp#1133