Skip to content

🐛 do not cancel context when rule parsing fails #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pranavgaikwad wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 do not cancel context when rule parsing fails #908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions kai_analyzer_rpc/pkg/service/pipe_analyzer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ func NewPipeAnalyzer(ctx context.Context, limitIncidents, limitCodeSnips, contex
Log: l.WithName("parser"),
}

discoveryRulesets, violationRulesets, neededProviders, providerConditions, err := parseRules(parser, rules, l, cancelFunc)
discoveryRulesets, violationRulesets, neededProviders, providerConditions, err := parseRules(parser, rules, l)
if err != nil {
return nil, err
return nil, fmt.Errorf("unable to parse rules: %w", err)
}

// Report rule parsing complete
Expand Down Expand Up @@ -194,7 +194,7 @@ func NewPipeAnalyzer(ctx context.Context, limitIncidents, limitCodeSnips, contex

}

func parseRules(parser parser.RuleParser, rules string, l logr.Logger, cancelFunc func()) ([]engine.RuleSet, []engine.RuleSet, map[string]provider.InternalProviderClient, map[string][]provider.ConditionsByCap, error) {
func parseRules(parser parser.RuleParser, rules string, l logr.Logger) ([]engine.RuleSet, []engine.RuleSet, map[string]provider.InternalProviderClient, map[string][]provider.ConditionsByCap, error) {
discoveryRulesets := []engine.RuleSet{}
violationRulesets := []engine.RuleSet{}
neededProviders := map[string]provider.InternalProviderClient{}
Expand All @@ -203,7 +203,6 @@ func parseRules(parser parser.RuleParser, rules string, l logr.Logger, cancelFun
internRuleSets, newNeededProviders, provConditions, err := parser.LoadRules(strings.TrimSpace(f))
if err != nil {
l.Error(err, "unable to parse all the rules for ruleset", "file", f)
cancelFunc()
return nil, nil, nil, nil, err
}
for k, v := range newNeededProviders {
Expand Down
Loading