Skip to content

🌱 Fix changelog fragment check for fork PRs #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
djzager merged 1 commit into from
Jul 21, 2026
Merged

🌱 Fix changelog fragment check for fork PRs #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/pr-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,20 @@ jobs:
if: contains(fromJSON('["feature", "bugfix", "breaking"]'), needs.verify.outputs.pr_type)
name: Verify changelog fragment
steps:
# actions/checkout refuses to check out fork PR code in a
# pull_request_target workflow, so check out the base repo and fetch
# the PR head as a ref that is only diffed, never checked out or run.
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
fetch-depth: 0
Comment thread
coderabbitai[bot] marked this conversation as resolved.
persist-credentials: false
- name: Fetch PR head ref
run: git fetch origin pull/${{ github.event.pull_request.number }}/head:pr-head
- name: Check for changelog fragment
env:
BASE_REF: ${{ github.event.pull_request.base.ref }}
run: |
FRAGMENTS=$(git diff --name-only --diff-filter=AM origin/${{ github.event.pull_request.base.ref }}...HEAD -- 'changes/unreleased/*.yaml' 'changes/unreleased/*.yml')
FRAGMENTS=$(git diff --name-only --diff-filter=AM "origin/${BASE_REF}...pr-head" -- 'changes/unreleased/*.yaml' 'changes/unreleased/*.yml')
if [ -z "$FRAGMENTS" ]; then
echo "::error::This is a ${{ needs.verify.outputs.pr_type }} PR — a changelog fragment is required in changes/unreleased/"
echo ""
Expand Down
Loading