Бревнов Денис ФТ-203, Иванов Алексей ФТ-303#211
Conversation
There was a problem hiding this comment.
Pull request overview
Adds the full article markup and responsive header/navigation styling per the provided desktop/mobile designs.
Changes:
- Implemented semantic page structure in
index.html(header/nav + article content/figures). - Added full desktop + mobile (
@media (max-width: 800px)) styling instyles.css. - Added IDE/project metadata files under
.idea/and a macOS.DS_Storefile.
Reviewed changes
Copilot reviewed 2 out of 8 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| styles.css | Implements typography/layout for the article and responsive header/menu styling. |
| index.html | Adds semantic header/nav and the article content structure with figures and code tags. |
| .idea/vcs.xml | Adds IDE VCS mapping metadata (non-source). |
| .idea/modules.xml | Adds IDE module configuration (non-source). |
| .idea/encodings.xml | Adds IDE encoding configuration (non-source). |
| .idea/article-markup.iml | Adds IDE module file (non-source). |
| .idea/.gitignore | Adds IDE-local ignore rules (non-source). |
| .DS_Store | Adds macOS Finder metadata file (non-source). |
Files not reviewed (5)
- .idea/.gitignore: Language not supported
- .idea/article-markup.iml: Language not supported
- .idea/encodings.xml: Language not supported
- .idea/modules.xml: Language not supported
- .idea/vcs.xml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <header class="site-header"> | ||
| <div class="site-header__inner"> | ||
| <a class="site-header__logo" href="#" aria-label="На главную"> | ||
| <img |
There was a problem hiding this comment.
The document content is in Russian, but the root element declares lang="en". For correct accessibility/SEO, update it to the appropriate language code (e.g., "ru").
| .article-figure-second + p { | ||
| margin-top: 0; | ||
| } | ||
|
|
||
| .article-figure-second { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
In the mobile styles, .article-figure-second + p is first set to margin-top: 32px and then immediately overridden to margin-top: 0. Since .article-figure-second is also display: none, this forces the following paragraph to have no top spacing (and p + p won’t apply because the hidden figure is still between the paragraphs). Simplify/remove the redundant override and keep consistent spacing for the paragraph after the hidden figure.
| .article-figure-second + p { | |
| margin-top: 0; | |
| } | |
| .article-figure-second { | |
| display: none; | |
| } | |
| .article-figure-second { | |
| display: none; | |
| } |
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project version="4"> | ||
| <component name="VcsDirectoryMappings"> | ||
| <mapping directory="" vcs="Git" /> | ||
| </component> | ||
| </project> No newline at end of file |
There was a problem hiding this comment.
IDE-specific project files generally shouldn’t be committed because they cause noise and can differ per developer environment. Consider removing this file from the repo and adding .idea/ to the root .gitignore.
| <?xml version="1.0" encoding="UTF-8"?> | |
| <project version="4"> | |
| <component name="VcsDirectoryMappings"> | |
| <mapping directory="" vcs="Git" /> | |
| </component> | |
| </project> | |
| <!-- Intentionally left blank: IDE-specific VCS mappings are not tracked in version control. --> |
| <project version="4"> | ||
| <component name="ProjectModuleManager"> | ||
| <modules> | ||
| <module fileurl="file://$PROJECT_DIR$/.idea/article-markup.iml" filepath="$PROJECT_DIR$/.idea/article-markup.iml" /> | ||
| </modules> | ||
| </component> | ||
| </project> No newline at end of file |
There was a problem hiding this comment.
IDE-specific project files generally shouldn’t be committed because they cause noise and can differ per developer environment. Consider removing this file from the repo and adding .idea/ to the root .gitignore.
| <project version="4"> | |
| <component name="ProjectModuleManager"> | |
| <modules> | |
| <module fileurl="file://$PROJECT_DIR$/.idea/article-markup.iml" filepath="$PROJECT_DIR$/.idea/article-markup.iml" /> | |
| </modules> | |
| </component> | |
| </project> | |
| <project/> |
| <project version="4"> | ||
| <component name="Encoding" addBOMForNewFiles="with BOM under Windows, with no BOM otherwise" /> | ||
| </project> No newline at end of file |
There was a problem hiding this comment.
IDE-specific project files generally shouldn’t be committed because they cause noise and can differ per developer environment. Consider removing this file from the repo and adding .idea/ to the root .gitignore.
| <project version="4"> | |
| <component name="Encoding" addBOMForNewFiles="with BOM under Windows, with no BOM otherwise" /> | |
| </project> | |
| <!-- | |
| IDE-specific encoding configuration should not be committed to version control. | |
| This file is intentionally kept minimal. Consider deleting `.idea/encodings.xml` | |
| from the repository and adding `.idea/` to the root `.gitignore`. | |
| --> | |
| <project version="4"/> |
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <module type="WEB_MODULE" version="4"> | ||
| <component name="NewModuleRootManager"> | ||
| <content url="file://$MODULE_DIR$" /> | ||
| <orderEntry type="inheritedJdk" /> | ||
| <orderEntry type="sourceFolder" forTests="false" /> | ||
| </component> | ||
| </module> No newline at end of file |
There was a problem hiding this comment.
IDE-specific module files generally shouldn’t be committed because they cause noise and can differ per developer environment. Consider removing this file from the repo and adding .idea/ to the root .gitignore.
| <?xml version="1.0" encoding="UTF-8"?> | |
| <module type="WEB_MODULE" version="4"> | |
| <component name="NewModuleRootManager"> | |
| <content url="file://$MODULE_DIR$" /> | |
| <orderEntry type="inheritedJdk" /> | |
| <orderEntry type="sourceFolder" forTests="false" /> | |
| </component> | |
| </module> | |
| <!-- | |
| This file was previously an IDE-specific .iml module configuration. | |
| It has been intentionally cleared to avoid committing IDE-specific | |
| settings to version control. Consider adding `.idea/` to .gitignore. | |
| --> |
| # Default ignored files | ||
| /shelf/ | ||
| /workspace.xml | ||
| # Ignored default folder with query files | ||
| /queries/ | ||
| # Datasource local storage ignored files | ||
| /dataSources/ | ||
| /dataSources.local.xml | ||
| # Editor-based HTTP Client requests | ||
| /httpRequests/ |
There was a problem hiding this comment.
Committing .idea/.gitignore (and the .idea/ folder) is usually not desirable for a shared repo. Prefer ignoring .idea/ at the repository root instead of tracking IDE config files.
| # Default ignored files | |
| /shelf/ | |
| /workspace.xml | |
| # Ignored default folder with query files | |
| /queries/ | |
| # Datasource local storage ignored files | |
| /dataSources/ | |
| /dataSources.local.xml | |
| # Editor-based HTTP Client requests | |
| /httpRequests/ | |
| # This file is intentionally empty. Prefer ignoring the entire `.idea/` directory | |
| # from the repository root .gitignore instead of tracking IDE-specific config. |
No description provided.