Skip to content

doc(STONEINTG-1434): testGraph logic#617

Open
jsztuka wants to merge 1 commit into
konflux-ci:mainfrom
jsztuka:STONEINTG-1434
Open

doc(STONEINTG-1434): testGraph logic#617
jsztuka wants to merge 1 commit into
konflux-ci:mainfrom
jsztuka:STONEINTG-1434

Conversation

@jsztuka

@jsztuka jsztuka commented May 18, 2026

Copy link
Copy Markdown
Contributor

User oriented documentation on how to specify exact order of integration test scenarios within their component group.

Three different examples were added:

  • Parallel tests
  • Sequence tests
  • Order tests

@jsztuka jsztuka requested a review from a team as a code owner May 18, 2026 15:29

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces documentation for specifying the order of integration tests using the testGraph attribute. The feedback highlights several critical issues: YAML syntax errors due to missing separators between resources, and inaccuracies in the explanation of test execution order where parallel execution was incorrectly described as sequential. Additionally, the review points out style guide violations regarding the missing page description and the need for imperative language, along with minor grammatical and typographical corrections.

Comment thread modules/testing/pages/integration/order.adoc
Comment thread modules/testing/pages/integration/order.adoc Outdated
Comment thread modules/testing/pages/integration/order.adoc Outdated
Comment thread modules/testing/pages/integration/order.adoc
Comment thread modules/testing/pages/integration/order.adoc Outdated
Comment thread modules/testing/pages/integration/order.adoc Outdated
Comment thread modules/testing/pages/integration/order.adoc Outdated
Comment thread modules/testing/pages/integration/order.adoc Outdated
@github-actions

Copy link
Copy Markdown

🚀 Preview is available at: https://pr-617--konflux-docs.netlify.app

@github-actions

Copy link
Copy Markdown

🚀 Preview is available at: https://pr-617--konflux-docs.netlify.app

@github-actions

Copy link
Copy Markdown

🚀 Preview is available at: https://pr-617--konflux-docs.netlify.app

@github-actions

Copy link
Copy Markdown

🚀 Preview is available at: https://pr-617--konflux-docs.netlify.app

@github-actions

Copy link
Copy Markdown

🚀 Preview is available at: https://pr-617--konflux-docs.netlify.app

Comment thread modules/testing/pages/integration/order.adoc
Comment thread modules/testing/pages/integration/order.adoc Outdated

@dirgim dirgim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, agree with Ryan's suggestions

@github-actions

Copy link
Copy Markdown

🚀 Preview is available at: https://pr-617--konflux-docs.netlify.app

@jsztuka

jsztuka commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

/on-hold
This PR will be merged once https://redhat.atlassian.net/browse/STONEINTG-1281 gets implemented.

@jsztuka jsztuka added the on-hold PR requires something that needs to be done prior merging. label May 19, 2026
Signed-off-by: Jiri Sztuka <jsztuka@redhat.com>
@github-actions

Copy link
Copy Markdown

🚀 Preview is available at: https://pr-617--konflux-docs.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on-hold PR requires something that needs to be done prior merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants