Client initialization, termsOfService key should be optional - #226
Open
TheStaticTurtle wants to merge 1 commit into
Open
Client initialization, termsOfService key should be optional#226TheStaticTurtle wants to merge 1 commit into
TheStaticTurtle wants to merge 1 commit into
Conversation
TheStaticTurtle
force-pushed
the
master
branch
from
December 22, 2022 11:48
4c8ad41 to
65a2f23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
During the client initialization, sewer expect that the
termsOfServiceurl is present in themetaof the endpoints.However,
termsOfServiceis optional (actually, themetakey itself is optional, see page 23 of RFC 8555) and while it works on most public servers, the TOS is not present on my self-hosted acme which causes the initialization to fail if it's not there.As this is actually used nowhere in the code, setting it to
Noneif not found has little impact and is probably the best option.Samuel.