Added Support for default prefixes in SPARQL queries (#647)#787
Merged
Conversation
mmarx
requested changes
May 12, 2026
mmarx
left a comment
mmarx
left a comment
Member
There was a problem hiding this comment.
This is mostly fine, only a few stylistic issues remain
mmarx
requested changes
Jun 15, 2026
mmarx
left a comment
mmarx
left a comment
Member
There was a problem hiding this comment.
A few more things, again mostly stylistic in nature. Also a lot of unneeded imports that cargo clippy --fix should be able to get rid of …
| ) | ||
| } | ||
|
|
||
| /// Return the FormatContext |
Member
There was a problem hiding this comment.
we should link the FormatContext here: [FormatContext]
| ) | ||
| } | ||
|
|
||
| /// Return the FormatContext |
Comment on lines
+149
to
+150
| /// Wrapper for IRI base and prefixes | ||
| /// Automatically attempts to resolve all relative prefixes on the base |
Member
There was a problem hiding this comment.
This should be more generic towards what it actually holds: “Additional context for import/export formats (e.g., base and prefixes)” or something like this, since this might evolve to contain even more in the future. The part about resolving prefixes should probably rather be on the add_prefix method.
| &self.prefixes | ||
| } | ||
|
|
||
| /// adds a base if None was set before |
Member
There was a problem hiding this comment.
We generally start comments with an uppercase letter (they should form a complete sentence) – this applies in some other places in the PR as well.
| } | ||
|
|
||
| /// adds a base if None was set before | ||
| /// panics if a base is already set |
Member
There was a problem hiding this comment.
this should also mention that it panics if the given base is not a valid (absolute) IRI
mmarx
requested changes
Jun 15, 2026
mmarx
left a comment
mmarx
left a comment
Member
There was a problem hiding this comment.
A few more things, again mostly stylistic in nature. Also a lot of unneeded imports that cargo clippy --fix should be able to get rid of …
Outputs traces for all IDB facts after reasoning. Fixes #783.
Flake lock file updates:
• Updated input 'crane':
'github:ipetkov/crane/dc7496d8ea6e526b1254b55d09b966e94673750f' (2026-04-19)
→ 'github:ipetkov/crane/edb38893982a3338972bb4a2ec7ce7c29ba10fd9' (2026-05-18)
• Updated input 'nemo-web':
'github:knowsys/nemo-web/f45b5648b26baa35ac1b3a6234dd39bc48bbe2cb' (2026-04-22)
→ 'github:knowsys/nemo-web/c8c3b8f55a092d4046ea729b14a29f0b9f033b14' (2026-05-18)
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/e07580dae39738e46609eaab8b154de2488133ce' (2026-04-19)
→ 'github:NixOS/nixpkgs/687f05a9184cad4eaf905c48b63649e3a86f5433' (2026-05-18)
• Updated input 'rust-overlay':
'github:oxalica/rust-overlay/40e6ccc06e1245a4837cbbd6bdda64e21cc67379' (2026-04-22)
→ 'github:oxalica/rust-overlay/8cd592658d4448c57326aaa819e1c2f91086eb40' (2026-05-19)
Signed-off-by: Maximilian Marx <mmarx@wh2.tu-dresden.de>
Flake lock file updates:
• Updated input 'nemo-vscode-extension':
'github:knowsys/nemo-vscode-extension/1df3577049b0f6f4a86da0e2ae6f289027a6ed01' (2026-06-04)
→ 'github:knowsys/nemo-vscode-extension/0b5d43bff010ea3c614f5d2fd4bfb9995fcbe436' (2026-06-04)
• Updated input 'nemo-web':
'github:knowsys/nemo-web/8a863710cc1b959c38a1001755424fd118251cdb' (2026-06-04)
→ 'github:knowsys/nemo-web/dec1dea448ad8115901d18e4f7dffc568fe4b5ed' (2026-06-04)
• Updated input 'nemo-web/nemo-vscode-extension':
'github:knowsys/nemo-vscode-extension/1df3577049b0f6f4a86da0e2ae6f289027a6ed01' (2026-06-04)
→ 'github:knowsys/nemo-vscode-extension/0b5d43bff010ea3c614f5d2fd4bfb9995fcbe436' (2026-06-04)
Signed-off-by: Maximilian Marx <mmarx@wh2.tu-dresden.de>
Work around a bug in cache-nix-action, cf. nix-community/cache-nix-action#170
mmarx
requested changes
Jun 24, 2026
mmarx
left a comment
mmarx
left a comment
Member
There was a problem hiding this comment.
A few more style nitpicks, but this is looking very good already!
added 2 commits
July 7, 2026 19:22
mmarx
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes base and prefix IRIs available to Import/Export and closes #647