Listen for jumpToRule message from nev#57
Conversation
monsterkrampe
force-pushed
the
feature/jump-to-rule
branch
6 times, most recently
from
bbf1ea0 to
fd51d68
Compare
|
the final version of this from nev is here: 8c3c13 |
mmarx
left a comment
mmarx
left a comment
There was a problem hiding this comment.
Looks good. I have a more philosophical question about changing the window title, but that's really not something for me to decide.
| // briefly change window title | ||
| const originalTitle = document.title; | ||
| document.title = "Rule Highlighted!"; | ||
| setTimeout(() => { | ||
| document.title = originalTitle; | ||
| }, 2000); |
There was a problem hiding this comment.
Is this really something we want to do? I'd find that pretty intrusive, when something like a flash message would suffice for this?
There was a problem hiding this comment.
Ah, well, this happens while the Nev tab is in foreground, doesn't it? Still, perhaps better to just prefix the existing title instead of overriding it completely?
There was a problem hiding this comment.
Yes, we were trying to find reliable ways to indicate to a user that they should switch the tab and to highlight which tab is even the relevant one. I'm also not quite happy with what we have but I also do not have a good solution in mind 😅
Prefixing instead of completely changing the title sounds better though. I'll change that :)
monsterkrampe
force-pushed
the
feature/jump-to-rule
branch
from
fd51d68 to
8b8ec7d
Compare
3 participants
Nev already reintroduced the "jump to rule" button on the blue rule boxes. The goal is that clicking the button automatically sets focus to the corresponding Nemo tab and makes the editor jump to the line featuring that rule.
This PR implements this functionality on the Nemo Web side.
This PR relies on knowsys/nemo#790.