Conversation
# Conflicts: # src/main/java/serenity/Event.java # src/main/java/serenity/Parser.java # src/main/java/serenity/Storage.java
# Conflicts: # src/main/java/serenity/TaskList.java
There are currently no assertion statements in the code. Assertion statements define our assumptions of the program state. These assumptions are verified at runtime, allowing errors to be caught early. Let's add some assertion statements to ensure our assumptions about the program state are true.
The current code has areas for improvement in terms of code quality. Improving code quality allows for code to be better read, understood and modified by other developers. Let's *Shorten methods *Improve logical structure of code *Remove unnecessary comments *Refactor by extracting methods
Add assertions
# Conflicts: # src/main/java/serenity/Parser.java
Improve code quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.