Fix resume:pdf hanging after PDF write#9
Merged
Conversation
Spawn the dev server in its own process group and signal the whole group on shutdown, so the orphaned astro/vite grandchildren can no longer keep the parent's stdio pipes (and Node's event loop) alive after vp itself exits. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for klinkink ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dosubot
Bot
added
size:S
Resolves binary conflict on src/assets/resume.pdf by taking main's updated copy (regenerated from the resume content changes in 6e04f44) and re-running resume:pdf to confirm reproducibility under the new process-group cleanup. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm resume:pdfwas writing the PDF correctly but the Node process never exited — you'd seewrote src/assets/resume.pdf …and then have to Ctrl-C.The script spawned the Astro dev server through Vite+'s wrapper:
vp run devis itself a wrapper that spawnsastro dev(which in turn spawns vite/esbuild/chokidar workers). Those grandchildren inherit our stdout/stderr pipe FDs.proc.kill("SIGTERM")only signaledvp; the grandchildren got orphaned, kept the pipes open, and Node's event loop refused to exit.Fix
In scripts/generate-resume-pdf.ts:
detached: trueso the child becomes a process-group leader.proc.kill(sig)withprocess.kill(-proc.pid, sig)to signal the whole group.proc.stdout?.destroy()/proc.stderr?.destroy()so any lingering inherited FD can't keep the loop alive.Test plan
pnpm resume:pdffinishes in ~8s and returns to the shell (was hanging indefinitely).ps -ef | grep -E "astro|vite|vp run"shows no orphaned processes after the script exits.src/assets/resume.pdf, 86891 bytes).tsc --noEmitis clean.🤖 Generated with Claude Code