Conversation
Signed-off-by: Iceber Gu <caiwei95@hotmail.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
plugins/template: fix a typo in a comment.
plugins/device-injector: fix a small typo in README.md.
stop closed plugins that will be removed
Signed-off-by: Yang Yang <yang8518296@163.com>
In some scenarios such as runtime restart or the occurrence of nri request timeout, the ttrpc connections between the plugin and the runtime will be actively closed by the runtime, even the underlying network connection will be closed together. After this, the plugin must need to re-register to the adaptation side, but now the stub object cannot be reused for this; if the running plugin wants to reconnect to the runtime, the only way is to create a new stub for the plugin. This commit has split the lifecycle of the stub and the ttrpc connection to better support the development of the external type of plugins. The plugin developer can build stub once and use it to connect to adaptation side many times, just need re-call Start() function. Signed-off-by: Lei Liu <liulei.pt@bytedance.com>
stub: support restart after stub stopped
support pids cgroup
Signed-off-by: Jitang Lei <leijitang@outlook.com>
types: Fix a typo
Add support for native CDI injection. With this in place, a plugin can now directly request injection of CDI devices by device name. This is much simpler than first performing CDI device resolution and injection, followed by a set of low- level NRI adjustments for devices, mounts, env. vars. and OCI hooks to effectively do the same. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Add support for injecting annotated CDI devices using the new native NRI CDI injection API. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Co-authored-by: Mike Brown <brownwm@us.ibm.com> Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Clarify order of preference for the possible annotations. Co-authored-by: Mike Brown <brownwm@us.ibm.com> Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
api: add support for NRI-native CDI injection
Signed-off-by: Xiaojin Zhang <874478410@qq.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Add support for adjusting OOM score adjustment.
Signed-off-by: Xiaojin Zhang <874478410@qq.com>
Co-authored-by: Mike Brown <brownwm@us.ibm.com> Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Reset source path of api.pb.go to pkg/api/api.proto
Add .codespellrc, fix reported existing spelling errors. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
…lure adaptation: close plugin if initial synchronization fails.
When a container mount is removed without replacing it by another mount to the same destination, NRI needs to pass the deletion to the runtime among the adjustments. Otherwise the mount will not get removed. Co-authored-by: Krisztian Litkey <krisztian.litkey@intel.com> Signed-off-by: jingtao.liang <jingtao.liang@easystack.cn>
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
…rized Add dockerized target for building proto files
Downgrade go to require 1.24.0
Drop unnecessary nolint directives and unify the style of remaining ones to match the rest of the codebase (and the golangci-lint documentation). Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
chore: clean and unify nolint directives
Signed-off-by: Neeraj Krishna Gopalakrishna <ngopalak@redhat.com>
…dea_editor nit: Add .idea folder to gitignore
This reverts commit f578ea2. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Image signatures can be verified with cosign. An example for the rolling
unstable image for the template plugin:
cosign verify ghcr.io/containerd/nri/plugins/template:unstable \
--certificate-identity-regexp "https://github.com/containerd/nri/.*" \
--certificate-oidc-issuer https://token.actions.githubusercontent.com \
| jq .
Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
Makes linters happier. Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
Mixed bag of comments for exported types. Makes revive happier. Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
Silence golangci-lint v2.4 errors that we don't want to fix. Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
…gnore-review .gitignore: revert hastily reviewed editor-specific addition.
ci: bump golangci-lint to v2.4
Disable: QF1008: could remove embedded field "Generator" from selector Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
…ositives golangci: disable QF1008 from staticcheck linter
ci: enable image signing
Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
…ustomize contrib: add example for enabling per-container RDT monitoring
Obtain the container's user, group and supplemental group IDs from OCI Spec.Process.User and expose it to plugins. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
…-info api: expose container user/group ID to plugins.
Install (and use) protoc and plugins under build/tools in the source tree in an attempt to ensure that the correct version of the tooling is always used. Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.