Skip to content

Subverso Highlighting#1

Draft
jcreedcmu wants to merge 6 commits into
klavins:mainfrom
jcreedcmu:pr-attempt2
Draft

Subverso Highlighting#1
jcreedcmu wants to merge 6 commits into
klavins:mainfrom
jcreedcmu:pr-attempt2

Conversation

@jcreedcmu

Copy link
Copy Markdown

Use subverso for highlighting instead of highlightjs.

To use:

cd md
make 
make deploy
make serve
# browse to localhost:8000
# for example, navigate to Maths > Sets > 11. Proving Set Equalites
# and hover over `subset_antisymm_iff`
image

Known problems: some of the highlight regions are wrong, still looking into it.

@klavins

klavins commented Mar 1, 2026

Copy link
Copy Markdown
Owner

So far this looks fantastic.

@klavins klavins marked this pull request as ready for review April 5, 2026 00:30
@klavins klavins marked this pull request as draft April 5, 2026 01:26
@klavins

klavins commented Apr 5, 2026

Copy link
Copy Markdown
Owner

I tested the PR and fixed a few issues that make it so that the highlight are aligned (at least in the cases I could find). Changes are on the subverso-fixes branch.

Do you think we can get to this to the point that we have proof states?

Specific changes:

  • index.html — added the missing subverso-highlight.js script tag (in both source and dist)
  • slider.js — moved the subverso highlighting call from dist-only to the source file so deploy doesn't overwrite it
  • subverso-highlight.js — replaced offset-based token matching with sequential string matching + word boundaries, fixing misaligned tooltips

@jcreedcmu

Copy link
Copy Markdown
Author

Nice! I'm actually wondering whether it might be feasible to swing you over to using https://github.com/leanprover/verso-slides , which didn't exist when we first talked --- it definitely does have full proof state visualization.

@klavins

klavins commented Apr 6, 2026

Copy link
Copy Markdown
Owner

Ok, I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants