Update data folders#66
Merged
Merged
Conversation
…lompe into update-data-folders
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy datadownloader module from lompe/data_tools, aligning the data tooling with the newer per-source downloader modules already present in the package.
Changes:
- Removed
lompe/data_tools/datadownloader.py(legacy downloader implementation).
Comments suppressed due to low confidence (1)
lompe/data_tools/datadownloader.py:1
- Deleting this module will break any code that still imports
lompe.data_tools.datadownloader(e.g.,lompe/data_tools/get_lompe_data.pycurrently doesfrom lompe.data_tools import datadownloader, dataloader). Either update/remove those imports (and any doc references) in the same PR, or keep a stubdatadownloader.pythat re-exports the new downloader functions for backward compatibility.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removing datadownloader and duplicated data_tools example.