feat: --theme + theme-aware batch (Phase 2c, the re-skin product surface) - #91
Merged
Conversation
…ace) Phase 2c. `render/frame/player --theme brand.json` applies a brand kit (a nested partial theme, flattened to a design.* overlay and composed first so --overlay still wins). `batch` gains a `design.<token.path>` column, so one data file renders one on-brand mp4 per row — on-brand video at scale. Reuses the 2b overlay machinery (composeScene); no core change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
themed-card-brands.json renders themed-card into vivid/mono/ocean mp4s in one batch; ocean.json is a nested brand kit for the --theme path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Guide/DESIGN.md/SKILL/READMEs/AGENTS document the now-complete design-token surface: token() for re-skinnable scenes, --theme brand kits, and per-brand batch. Bumps the plugin to 0.1.13 (SKILL.md change). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2c — the one-command product surface over the 2a/2b engine capability. No core change (reuses the 2b overlay machinery), so goldens are trivially unchanged.
What
render/frame/player --theme brand.json— apply a brand kit. A kit is a nested partial theme ({ "color": { "accent": "#1E90FF" } });loadThemeDocflattens it to adesign.*overlay and composes it first, so a--overlaycan still override it. (render-cli/overlay.ts, threaded through each command's flag loop.)batch—overlayFromFlatgains adesign.<token.path>column, so one data file renders one on-brand mp4 per row (the "on-brand video at scale" payoff)._namealready names each mp4.Demo
reframe batch examples/scenes/themed-card.ts examples/data/themed-card-brands.json→vivid.mp4/mono.mp4/ocean.mp4(verified: 3 rendered, 4 edits each, 0 orphans).reframe frame themed-card.ts --t 1 --theme examples/themes/ocean.jsonre-skins vs the base.Docs
token()re-skin +--theme+ batchdesign.*taught in the eDSL guide, DESIGN.md, SKILL.md, both READMEs, and AGENTS.md (new design-tokens entry). Plugin bumped0.1.12 → 0.1.13(SKILL.md change).Verification
pnpm test— 442 pass (438 + 4 newtheme-cli.test.ts:flattenTokens,loadThemeDoc, batchdesigncolumn); goldens byte-identical (no core/evaluatechange);pnpm typecheck+pnpm lintclean.reframe batch …emits 3 distinctly-branded mp4s;frame --themediffers from base.Next (2d, optional)
Scene-
backgroundtokens; numeric/type tokens (IR type-widening); gradient-stop tokens. Separately, areframe-videonpm patch would put the newtheme/brand/token/designAPI +--themein reach of npm/Agent-SDK consumers.🤖 Generated with Claude Code