Skip to content

Make test workflow failures blocking#822

Merged
kitsuyui merged 1 commit into
mainfrom
enforce-test-workflow-failures
May 5, 2026
Merged

Make test workflow failures blocking#822
kitsuyui merged 1 commit into
mainfrom
enforce-test-workflow-failures

Conversation

@kitsuyui
Copy link
Copy Markdown
Owner

@kitsuyui kitsuyui commented May 5, 2026

Summary

  • Remove continue-on-error from the test workflow so lint, test, build, and build-size failures block the check.
  • Keep the existing workflow triggers, permissions, and steps unchanged.

Validation

  • git diff --check
  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/test.yml"); puts "yaml ok"'\n- actionlint .github/workflows/test.yml\n- bun run lint\n- bun run test\n- bun run build && git diff --stat --exit-code -- dist\n\nNote: the build currently emits upstream dependency type export warnings from ajv / fast-uri, but it exits successfully and leaves dist unchanged.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

🎉 Happy commit!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Code Metrics Report

main (4cc8b0c) #822 (d7f3c76) +/-
Coverage 99.0% 99.0% 0.0%
Code to Test Ratio 1:0.5 1:0.5 0.0
Test Execution Time 1s 1s 0s
Details
  |                     | main (4cc8b0c) | #822 (d7f3c76) | +/-  |
  |---------------------|----------------|----------------|------|
  | Coverage            |          99.0% |          99.0% | 0.0% |
  |   Files             |              5 |              5 |    0 |
  |   Lines             |            107 |            107 |    0 |
  |   Covered           |            106 |            106 |    0 |
  | Code to Test Ratio  |          1:0.5 |          1:0.5 |  0.0 |
  |   Code              |           1386 |           1386 |    0 |
  |   Test              |            758 |            758 |    0 |
  | Test Execution Time |             1s |             1s |   0s |

Reported by octocov

@kitsuyui kitsuyui merged commit 197c320 into main May 5, 2026
5 checks passed
@kitsuyui kitsuyui deleted the enforce-test-workflow-failures branch May 5, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant