Skip to content

Require additional rule fields in schema validation#819

Merged
kitsuyui merged 1 commit into
mainfrom
codex/require-additional-rule-fields
May 4, 2026
Merged

Require additional rule fields in schema validation#819
kitsuyui merged 1 commit into
mainfrom
codex/require-additional-rule-fields

Conversation

@kitsuyui
Copy link
Copy Markdown
Owner

@kitsuyui kitsuyui commented May 4, 2026

Summary

  • Require kind, rule, and message on each additional_rules entry in the runtime Ajv schema.
  • Generate schema.json with required fields so the published schema matches the runtime contract.
  • Add regression coverage for missing custom-rule fields and rebuild the checked-in action bundle.

Validation

  • bun install --frozen-lockfile
  • bun run generate-json-schema
  • bun run format
  • bun run lint
  • bun run test
  • bun run build

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

gh-counter

  • TODO/FIXME: 0 (base: 0, delta: 0)

Reported by gh-counter

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

🎉 Happy commit!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Code Metrics Report

main (1151ca7) #819 (d85672c) +/-
Coverage 99.0% 99.0% 0.0%
Code to Test Ratio 1:0.5 1:0.5 +0.0
Test Execution Time 1s 1s 0s
Details
  |                     | main (1151ca7) | #819 (d85672c) | +/-  |
  |---------------------|----------------|----------------|------|
  | Coverage            |          99.0% |          99.0% | 0.0% |
  |   Files             |              5 |              5 |    0 |
  |   Lines             |            107 |            107 |    0 |
  |   Covered           |            106 |            106 |    0 |
+ | Code to Test Ratio  |          1:0.5 |          1:0.5 | +0.0 |
  |   Code              |           1370 |           1386 |  +16 |
+ |   Test              |            743 |            758 |  +15 |
  | Test Execution Time |             1s |             1s |   0s |

Code coverage of files in pull request scope (100.0% → 100.0%)

Files Coverage +/- Status
src/validate.ts 100.0% 0.0% modified

Reported by octocov

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

gh-build-size

Target main #819 +/-
Total action artifacts 23,184,161 B 23,290,052 B +105,891 B
Runtime bundle 1,132,728 B 1,151,843 B +19,115 B
Source maps 17,037,154 B 17,122,599 B +85,445 B
Type declarations 4,973,308 B 4,973,541 B +233 B

Reported by gh-build-size

@kitsuyui kitsuyui merged commit 3e38265 into main May 4, 2026
5 checks passed
@kitsuyui kitsuyui deleted the codex/require-additional-rule-fields branch May 4, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant