Skip to content

Cover install helper branches with focused tests#89

Open
kitsuyui wants to merge 1 commit into
mainfrom
queue/metric-audit-001
Open

Cover install helper branches with focused tests#89
kitsuyui wants to merge 1 commit into
mainfrom
queue/metric-audit-001

Conversation

@kitsuyui

Copy link
Copy Markdown
Owner

Summary

Cover install helper branches with focused tests

Extract the pure InfoPlist.strings conversion and exec-script generation
helpers from install-app-forked-lite.ts into a dedicated module, then add
focused Vitest coverage for Firefox, Chromium tabbed, and Chromium app-mode
script generation plus strings2Obj and obj2Strings behavior. This keeps
the forked installer flow and runtime behavior unchanged while making the
branch-heavy install responsibility directly observable from the existing test
suite.

Chosen fix

  • approach: extract-and-test-install-script-pure-helpers
    The highest-risk gap in this finding is pure branch-heavy logic that lives
    inside a process- and filesystem-heavy installer entrypoint. Extracting only
    those deterministic helpers is the smallest safe implementation because it
    improves coverage representativeness without introducing new harnesses,
    changing repository settings, weakening quality gates, or altering supported
    runtime versions. Side-effect-heavy installation steps remain untouched, but
    the Firefox/Chromium decision logic and InfoPlist.strings transforms now
    have direct regression checks.

@github-actions

Copy link
Copy Markdown

gh-counter

PR gate

Removed Added +/-
TODO/FIXME 0 0 0
Type escape 0 0 0
Lint suppression 1 1 0
Electron webPreferences risk 0 0 0

Repo dashboard

main (a03e5b6) #89 (bbc13ad) +/-
TODO/FIXME 0 0 0
Type escape 1 1 0
Lint suppression 36 36 0
Electron webPreferences risk 0 0 0
Lint suppression patch breakdown
File Removed Added +/-
main-src/libs/app-management/install-app-async/install-app-forked-lite-helpers.ts 0 1 +1
main-src/libs/app-management/install-app-async/install-app-forked-lite.ts 1 0 -1
Lint suppression repository breakdown
File main (a03e5b6) #89 (bbc13ad) +/-
main-src/libs/app-management/install-app-async/install-app-forked-lite-helpers.ts 0 1 +1
main-src/libs/app-management/install-app-async/install-app-forked-lite.ts 1 0 -1

Reported by gh-counter

@github-actions

Copy link
Copy Markdown

Code Metrics Report

main (a03e5b6) #89 (bbc13ad) +/-
Coverage 41.1% 42.9% +1.7%
Code to Test Ratio 1:0.3 1:0.3 +0.0
Test Execution Time 7s 7s 0s
Details
  |                     | main (a03e5b6) | #89 (bbc13ad) |  +/-  |
  |---------------------|----------------|---------------|-------|
+ | Coverage            |          41.1% |         42.9% | +1.7% |
  |   Files             |            146 |           147 |    +1 |
  |   Lines             |           2578 |          2582 |    +4 |
+ |   Covered           |           1061 |          1109 |   +48 |
+ | Code to Test Ratio  |          1:0.3 |         1:0.3 |  +0.0 |
  |   Code              |          13389 |         13518 |  +129 |
+ |   Test              |           4299 |          4383 |   +84 |
  | Test Execution Time |             7s |            7s |    0s |

Code coverage of files in pull request scope (0.0% → 24.0%)

Files Coverage +/- Status
main-src/libs/app-management/install-app-async/install-app-forked-lite-helpers.ts 94.1% +94.1% added
main-src/libs/app-management/install-app-async/install-app-forked-lite.ts 0.0% 0.0% modified

Reported by octocov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant