Cover install helper branches with focused tests#89
Open
kitsuyui wants to merge 1 commit into
Open
Conversation
gh-counterPR gate
Repo dashboard
|
| File | Removed | Added | +/- |
|---|---|---|---|
main-src/libs/app-management/install-app-async/install-app-forked-lite-helpers.ts |
0 | 1 | +1 |
main-src/libs/app-management/install-app-async/install-app-forked-lite.ts |
1 | 0 | -1 |
Lint suppression repository breakdown
Reported by gh-counter
Code Metrics Report
Details | | main (a03e5b6) | #89 (bbc13ad) | +/- |
|---------------------|----------------|---------------|-------|
+ | Coverage | 41.1% | 42.9% | +1.7% |
| Files | 146 | 147 | +1 |
| Lines | 2578 | 2582 | +4 |
+ | Covered | 1061 | 1109 | +48 |
+ | Code to Test Ratio | 1:0.3 | 1:0.3 | +0.0 |
| Code | 13389 | 13518 | +129 |
+ | Test | 4299 | 4383 | +84 |
| Test Execution Time | 7s | 7s | 0s |Code coverage of files in pull request scope (0.0% → 24.0%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cover install helper branches with focused tests
Extract the pure
InfoPlist.stringsconversion and exec-script generationhelpers from
install-app-forked-lite.tsinto a dedicated module, then addfocused Vitest coverage for Firefox, Chromium tabbed, and Chromium app-mode
script generation plus
strings2Objandobj2Stringsbehavior. This keepsthe forked installer flow and runtime behavior unchanged while making the
branch-heavy install responsibility directly observable from the existing test
suite.
Chosen fix
The highest-risk gap in this finding is pure branch-heavy logic that lives
inside a process- and filesystem-heavy installer entrypoint. Extracting only
those deterministic helpers is the smallest safe implementation because it
improves coverage representativeness without introducing new harnesses,
changing repository settings, weakening quality gates, or altering supported
runtime versions. Side-effect-heavy installation steps remain untouched, but
the Firefox/Chromium decision logic and
InfoPlist.stringstransforms nowhave direct regression checks.