Clear installed scan state after scan failures#88
Merged
Conversation
gh-counterPR gate
Repo dashboard
Reported by gh-counter |
Code Metrics Report
Details | | main (a03e5b6) | #88 (b93fd23) | +/- |
|---------------------|----------------|---------------|-------|
+ | Coverage | 41.1% | 41.4% | +0.2% |
| Files | 146 | 147 | +1 |
| Lines | 2578 | 2582 | +4 |
+ | Covered | 1061 | 1069 | +8 |
+ | Code to Test Ratio | 1:0.3 | 1:0.3 | +0.0 |
| Code | 13389 | 13440 | +51 |
+ | Test | 4299 | 4332 | +33 |
| Test Execution Time | 7s | 7s | 0s |Code coverage of files in pull request scope (0.0% → 44.4%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clear installed scan state after scan failures
Centralize installed-app scan finalization so the Installed page always
receives
set-scanning-for-installed(false), even when scanning rejects.Keep the existing IPC error dialog path unchanged and cover the shared scan
lifecycle with a focused regression test.
Chosen fix
The observed bug is a missing failure-side state reset, but the safest minimal fix is to centralize scan finalization where scan lifecycle already starts (
clean-app-management) instead of patching only the IPC catch block. That removes the split-brain ownership where success clears scanning in one file and failure would clear it in another, while keeping scope limited to the installed-app scan path and avoiding any repo-policy conflicts.