collect unmatched tokens#15
Open
stereosteve wants to merge 1 commit into
Open
Conversation
Member
|
Hi Steve, I was playing around with something similar quite a while back on the return-ignored branch. It did what you implemented but also checked if any input caused no change to the output. I believe it still fails on some edge cases. There is a demo up as well. Should have opened a pull-request for visibility. The way you just add it as a prop on the return object is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Kaspar,
One thing that might be nice is the ability to collect the extraneous tokens, so that if user enters
100nF 0603 50V Kemet, theKemettoken could be used for full text search.This is a pretty hack-y way to do it, and it breaks the return behavior of
{}for no match. I've not used Nearly before, so believe there is probably a better way to do this, but thought I would create PR just to get your thoughts.