feat: upload video and screenshot attachments without a trace - #34
Merged
Conversation
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing a video or screenshot in kinora required
trace: 'on':isTraceAttachmentgated uploads to zips, so with tracing off they stayed metadata pointing at a dead CI-runner path. Playwright doesn't couple them, our upload filter did.Both ingest paths now filter by attachment kind, opt-in,
['trace']by default:No
on-failurefiltering:screenshot: 'only-on-failure'andvideo: 'retain-on-failure'already decide what exists.Two server bugs this uncovered, harmless while only zips were uploaded:
.zip, and/artifacts/*types responses from it, so a webm would have been served asapplication/zip. Extension now derives from the content type; trace keys keep their previous shape.toHaveScreenshotassertions (both attachactual) shared one url. Urls are now queued per name, in upload order.Dashboard badges link to
a.urlwhen hosted, else fall back to the viewer's Attachments tab.Refs #18.