feat(server): self-host retention policy with in-process sweep - #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-host had no cleanup path:
purgeExpiredRunsreturned early whenKINORA_CLOUD=false, and nothing in the repo schedules a sweep. Traces grow forever.Three env knobs, all
0(keep everything) by default:KINORA_ARTIFACT_RETENTION_DAYS- deletes stored trace files past N days but keeps the runs. Screenshots and videos ride insidetrace.zip, so this is where the disk actually goes; pass rates, trends and flaky history survive, old runs just lose their trace link.KINORA_RETENTION_DAYS- deletes whole runs past N days.KINORA_KEEP_LAST_RUNS- keeps the N newest runs per project.The server sweeps at startup and every 24h while at least one is non-zero.
Refs #18 - the retention half. Uploading video/screenshot when
traceis off is still open.