added markdown, python script, R script, sql dump#30
Open
hchan7 wants to merge 1 commit into
Open
Conversation
kimpenguin
reviewed
Oct 26, 2021
| @@ -0,0 +1,3 @@ | |||
| # Intro | |||
Owner
There was a problem hiding this comment.
Thanks for this new file! Look good!
kimpenguin
requested changes
Oct 26, 2021
kimpenguin
left a comment
kimpenguin
left a comment
Owner
There was a problem hiding this comment.
Thanks for contributing @hchan7 ! A couple updates before I can approve.
The R, python, and sql file you added are all in folders inside the markdown folder. Could you move them to the relevant folders at the root of the repository and then append your username to each file like index.R to index-hchan7.R? This way, we can keep the files in their corresponding folders and also avoid future merge conflicts is there are many users updating the same file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.