Skip to content

Testing pull list#25

Open
Mercier1122 wants to merge 1 commit into
kimpenguin:mainfrom
Mercier1122:dave
Open

Testing pull list#25
Mercier1122 wants to merge 1 commit into
kimpenguin:mainfrom
Mercier1122:dave

Conversation

@Mercier1122

Copy link
Copy Markdown

No description provided.

Comment thread markdown/Lucian1.md
@@ -0,0 +1,3 @@
#Intro

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This markdown's looking good! If you could, please update the filename to Mercier1122.md just in case a user with the username Lucian1 happens to add their own markdown file. This will help us prevent file conflicts.

@kimpenguin kimpenguin left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mercier1122 ! Couples updates to make before I can approve this request.

  1. Update the markdown filename
  2. Looks like you created a dump.sql folder with a file called sql in the markdown folder. Since there's a sql folder at the root of this repository, can you remove the dump.sql folder you created and add a dump-Mercier1122.sql file inside the sql folder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants