adding markdown, python and r scripts for manthanshah94#24
Open
manthanshah94 wants to merge 1 commit into
Open
adding markdown, python and r scripts for manthanshah94#24manthanshah94 wants to merge 1 commit into
manthanshah94 wants to merge 1 commit into
Conversation
kimpenguin
reviewed
Oct 26, 2021
| @@ -0,0 +1,3 @@ | |||
| # Intro | |||
Owner
There was a problem hiding this comment.
This is looking great! A couple edits needed on this file.
- In order for the markdown to properly render your formatted text, you need to add the
.mdfile extension. - While you're updating this filename, could you also rename it from
whoismanthan.mdtomanthanshah94.md. With this filename update, if there is a chance that a user with the usernamewhoismanthanwants to add a markdown, it won't conflict with yours.
ame whoismanthan
kimpenguin
requested changes
Oct 26, 2021
kimpenguin
left a comment
Owner
There was a problem hiding this comment.
Thanks for contributing! Just a couple changes before I can approve.
One comment is on your markdown.
The other is if you could move your markdown/R-scripts/index.R to R-scripts/index.R. The R-scripts directory at the root of this repository if where we're storing all our R scripts, so we don't want to keep it in the markdown folder. Also, please append your username to the index file like index-manthanshah94.R. This way, we can avoid file conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.