Skip to content

adding markdown, python and r scripts for manthanshah94#24

Open
manthanshah94 wants to merge 1 commit into
kimpenguin:mainfrom
manthanshah94:manthanshah94
Open

adding markdown, python and r scripts for manthanshah94#24
manthanshah94 wants to merge 1 commit into
kimpenguin:mainfrom
manthanshah94:manthanshah94

Conversation

@manthanshah94

Copy link
Copy Markdown

No description provided.

Comment thread markdown/whoismanthan
@@ -0,0 +1,3 @@
# Intro

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! A couple edits needed on this file.

  1. In order for the markdown to properly render your formatted text, you need to add the .md file extension.
  2. While you're updating this filename, could you also rename it from whoismanthan.md to manthanshah94.md. With this filename update, if there is a chance that a user with the username whoismanthan wants to add a markdown, it won't conflict with yours.

ame whoismanthan

@kimpenguin kimpenguin left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Just a couple changes before I can approve.

One comment is on your markdown.

The other is if you could move your markdown/R-scripts/index.R to R-scripts/index.R. The R-scripts directory at the root of this repository if where we're storing all our R scripts, so we don't want to keep it in the markdown folder. Also, please append your username to the index file like index-manthanshah94.R. This way, we can avoid file conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants