adding markdown, python script, sql dump for katrinali7#19
Open
katrinali7 wants to merge 1 commit into
Open
Conversation
kimpenguin
reviewed
Oct 26, 2021
| @@ -0,0 +1 @@ | |||
| print('Hello World') No newline at end of file | |||
Owner
There was a problem hiding this comment.
can you rename this file from main.py to main-katrinali7.py?
kimpenguin
reviewed
Oct 26, 2021
| @@ -0,0 +1,2 @@ | |||
| select * | |||
Owner
There was a problem hiding this comment.
Can you rename this file from dump.sql to dump-katrinali7.sql?
kimpenguin
requested changes
Oct 26, 2021
kimpenguin
left a comment
kimpenguin
left a comment
Owner
There was a problem hiding this comment.
@katrinali7 , these files all look great! Please address the comments and update this pull request for me to go ahead with the approval. By updating the filenames, we can ensure that there are fewer merge conflicts as people contribute to the same file or others in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.