fix: v2.1.1 adversarial P1s (Codex gpt-5.6-sol) - #81
Merged
Conversation
Address gpt-5.6-sol@high BLOCK findings: - VS Code: spawn argv shell:false (no sendText injection) - animation: CT_Slide order, numeric slide sort, force required, appear path - refine: deferred inserts so multi-slide density patches stay stable - generative: preserve overflow; validate placements; wire LAYOUT_CMD - extract: barDir=col → column - Windows bootstrap: pin package, safe InstallRoot, SHA optional, exact exe - public benchmark: recipe smoke + honest synthetic-suite docs - check-plugin exact version equality; bump 2.1.1 351 tests OK; npm check green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to Codex
gpt-5.6-sol@high adversarial review which returned BLOCK on v2.1.0 marketing/security gaps.P1 fixes
spawn+ argv,shell:false— no shell-joined feedbackcontent.overflowpreserve; placement validation; LAYOUT_CMD wiredbarDir=col→ columndesignmd-pptx==2.1.1, safe root, SHA optional, officecli.exe onlyVersion
2.1.1 (patch). Exact version equality in
npm run check.Test plan
npm run checkbenchmark --public --public-n 20PASS with recipe_build notesCloses adversarial pre-announce gaps for v2.1 announce (ship-with-fixes path).