This repository was archived by the owner on Sep 19, 2023. It is now read-only.
Should fix POS Pro custom templates not found#173
Open
thomasmery wants to merge 1 commit into
Open
Conversation
seemed like it was not possible to add custom templates for Pos Pro Screens this fix passes along the pos pro template dir path so it can be used as the string to be replaced when building the theme woocommerce-pos template dir path without this fix the `locate_template_file` method would not replace the template dir path as it was set to the woocommerce pos template dir path and not found in the template path passed to the method
|
While doing something similar, I think I recognized the version 0.5 comes with a new implementation of templates so I gave up, but thanks for this @thomasmery - will probably make use of it until o.5 reaches a stable state. 🤓 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this might be fixed in 0.5 but I can't really test right now as I'm developing on a WC 3.0 install and don't have time to setup something proper with 2.6
and also as I needed this I thought it might be useful to 0.4 for now
I can port it to 0.5 if necessary
anyways
seemed like it was not possible to add custom templates for Pos Pro Screens
this fix passes along the pos pro template dir path so it can be used as the string to be replaced when building the theme woocommerce-pos template dir path
without this fix the
locate_template_filemethod would not replace the template dir path as it was set to the woocommerce pos template dir path and not found in the template path passed to the method