Skip to content

fix: plugin v2 compatibility - #297

Open
Malaydewangan09 wants to merge 18 commits into
mainfrom
fix/v2
Open

fix: plugin v2 compatibility#297
Malaydewangan09 wants to merge 18 commits into
mainfrom
fix/v2

Conversation

@Malaydewangan09

@Malaydewangan09 Malaydewangan09 commented Apr 10, 2026

Copy link
Copy Markdown
Member

@Malaydewangan09 Malaydewangan09 self-assigned this Apr 10, 2026
@github-actions

github-actions Bot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

🧪 Java Unit Tests

TestsPassed ☑️SkippedFailed ❌️Time ⏱
Java Tests Report206 ran204 ✅0 ⚠️2 ❌4m 21s 41ms
TestResultTime ⏱
Java Tests Report
TriggerTest.moveAction()❌ failure1m 180ms
TriggerTest.noneAction()❌ failure1m 129ms

📦 Artifacts

Name Size Updated Expiration
jar 11.01 MB May 7, 26, 6:20:06 PM UTC May 14, 26, 6:20:04 PM UTC

🔁 Unreleased Commits

✅ No unreleased commits found.

@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

Tests report quick summary:

failed ❌ > tests: 206, success: 204, skipped: 0, failed: 2

Project Status Success Skipped Failed
plugin-fs failed ❌ 204 0 2

Failed tests:

plugin-fs > io.kestra.plugin.fs.local.TriggerTest > moveAction() failed ❌ in 60.180
java.lang.AssertionError: &#10;Expected: is <true>&#10;     but: was <false>

java.lang.AssertionError: 
Expected: is <true>
     but: was <false>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
	at io.kestra.plugin.fs.local.AbstractTriggerTest.moveAction(AbstractTriggerTest.java:65)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension$2.proceed(MicronautJunit5Extension.java:154)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptEach(AbstractMicronautExtension.java:171)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptTest(AbstractMicronautExtension.java:128)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension.interceptTestMethod(MicronautJunit5Extension.java:141)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)

plugin-fs > io.kestra.plugin.fs.local.TriggerTest > noneAction() failed ❌ in 60.129
java.lang.AssertionError: &#10;Expected: is <true>&#10;     but: was <false>

java.lang.AssertionError: 
Expected: is <true>
     but: was <false>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
	at io.kestra.plugin.fs.local.AbstractTriggerTest.noneAction(AbstractTriggerTest.java:102)
	at java.base/java.lang.reflect.Method.invoke(Method.java:565)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension$2.proceed(MicronautJunit5Extension.java:154)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptEach(AbstractMicronautExtension.java:171)
	at io.micronaut.test.extensions.AbstractMicronautExtension.interceptTest(AbstractMicronautExtension.java:128)
	at io.micronaut.test.extensions.junit5.MicronautJunit5Extension.interceptTestMethod(MicronautJunit5Extension.java:141)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1604)

Match the v2 trigger test pattern used in AbstractFileTriggerTest:
inject Scheduler, wait for it to be active, declare flows via @LoadFlows
per test, and use a 1-min latch. The previous setup relied on flows
being visible after scheduler init, which CachedFlowMetaStore does not
support (single startup scan, no rescan).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant