Architecture cleanup: remove duplication and tighten types

[kertal]

Consolidation-focused architecture pass. The data-flow layering was already sound; the drag was duplication that had silently forked (two fetch stacks, two filter stacks, several item-type classifiers, two context-type definitions), with one fork already quietly wrong. Each change is its own commit, and the test suite (476 passing) plus a production build (tsc && vite build) were green after every step.

Changes

1. Remove orphaned githubSearch fetch stack — performGitHubSearch/fetchUserItems (624 lines + 35 tests) were never wired into any production path; the live fetching lives inline in useGitHubDataFetching. Deleted the module, its tests, the dead test mock, and the now-unused UsernameCache type.

2. Consolidate filtering & classification into one module — Deleted resultsUtils.ts and filterUtils.ts, whose entire filter/classify API was unused in production (only parseSearchText and the ResultsFilter type were live). This removed a second, stale copy of the filtering logic that had already drifted — getItemType matched a 'Reviewed:' title prefix no item ever has. Moved parseSearchText into the live viewFiltering.ts and ResultsFilter/createDefaultFilter into urlState.ts (their only consumers), and added a canonical isReviewItem() used everywhere review detection was duplicated.

3. Make IndexedDB storage generic over item type — The search-items store actually holds GitHubItem[] but was typed as GitHubEvent[] end-to-end, forcing as unknown as casts at every read/write. Parameterized EventsData<T>, eventsStorage.store/retrieve, and useIndexedDBStorage<T> so events and search items are typed honestly. Removes all storage-layer casts.

4. Deduplicate FormContextType — It was defined both inline in App.tsx and in types.ts, and the two had drifted. Made types.ts the single definition matching the value App actually provides.

5. Refactor transformEventToItem into a dispatch table — Replaced the ~500-line if/else-on-event.type chain with a Record<eventType, handler> map plus shared buildBaseItem/actorUserOf helpers. Behavior is identical (event-transform tests unchanged).

6. Smaller cleanups — Extracted a LoadingScreen component (~130 lines) out of App.tsx; removed unreachable code after a throw; dropped debug console.logs; moved 12 root-level *_FIX.md/*_FEATURE.md process notes into docs/.

Verification

• npx vitest run → 476 passing, 13 skipped
• npm run build (tsc && vite build) → success
• Lint: the changed files are clean. npm run lint still reports pre-existing problems in untouched test/e2e files (not introduced here).

Notes

• No behavior changes intended — this is a refactor. The deletions in steps 1–3 are backed by the existing test coverage.

🤖 Generated with Claude Code

https://claude.ai/code/session_01UgXeFcjEWsdHPRgb2Whcxh

---

Generated by Claude Code

[coderabbitai]

Warning

Review limit reached

@kertal, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 16ae8641-14cf-46e1-a746-b6d579835432

📥 Commits

Reviewing files that changed from the base of the PR and between 137b230 and 424bd0a.

📒 Files selected for processing (3)

• .gitignore
• src/utils/README.md
• src/utils/rawDataUtils.ts

📝 Walkthrough

Walkthrough

This PR removes githubSearch.ts, resultsUtils.ts, and filterUtils.ts (with their tests), inlining search-text parsing into viewFiltering.ts and urlState.ts. It generalizes IndexedDB storage with generics, refactors rawDataUtils into a handler dispatch table, adds a LoadingScreen component, updates FormContextType, and adds review-grouping logic and build configs.

Changes

Utility consolidation and typed data flow

Layer / File(s)	Summary
FormContextType updates src/types.ts	Adds searchText/setSearchText, simplifies handleSearch, requires rawEventsCount, removes UsernameCache.
Generic IndexedDB storage src/utils/indexedDB.ts, src/hooks/useIndexedDBStorage.ts	Adds EventsMetadata, generic EventsData<T>, generic storeEvents/getEvents/store/retrieve, and generic useIndexedDBStorage<T> hook.
Data hooks typed to storage src/hooks/useGitHubDataFetching.ts, src/hooks/useGitHubDataProcessing.ts, src/hooks/useGitHubFormState.ts	Uses GitHubItem[]/EventsMetadata types, removes unsafe casts, simplifies error handling and debug logging.
Removed legacy search/filter modules, inlined parsing src/utils/githubSearch.ts, src/utils/resultsUtils.ts, src/utils/filterUtils.ts (+tests), src/utils/viewFiltering.ts, src/utils/urlState.ts, src/utils/__tests__/searchParsing.test.ts, src/test/*	Deletes GitHub search/results/filter utilities and tests, adds local parseSearchText/ResultsFilter/createDefaultFilter, and new search-parsing test suite.
rawDataUtils dispatch refactor src/utils/rawDataUtils.ts	Replaces if/else event mapping with eventHandlers dispatch table using shared actorUserOf/buildBaseItem helpers.
Review item detection src/utils/summaryGrouping.ts, src/views/Summary.tsx	Adds isReviewItem helper used across getEventType, categorizeItem, and groupItemsByUrl.
LoadingScreen component and App wiring src/components/LoadingScreen.tsx, src/App.tsx	Adds LoadingScreen with ready-state logic, replaces inline loading UI in App.tsx.
Build/test configs and docs vite.config.*, vitest.config.*, tsconfig*.tsbuildinfo, src/utils/README.md	Adds Vite/Vitest configuration files, regenerates build metadata, and rewrites utils README.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
  participant App
  participant LoadingScreen
  participant useIndexedDBStorage
  participant eventsStorage
  App->>useIndexedDBStorage: load typed events (GitHubEvent/GitHubItem)
  useIndexedDBStorage->>eventsStorage: retrieve<T>(key)
  eventsStorage-->>App: typed events + metadata
  App->>LoadingScreen: render(loading, isDataLoadingComplete, progress)
  LoadingScreen-->>App: onManualSpin() / onStart()

Loading

Poem

A rabbit hopped through tangled code,
Swept old files off the road,
Typed each carrot, generic and neat,
Loading screens now look so sweet,
Hop hop hooray, the build's complete! 🥕✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main refactor: removing duplication and tightening types.
Description check	✅ Passed	The description is clearly about the same architecture cleanup and matches the code changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/code-architecture-review-guobxg

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 5

♻️ Duplicate comments (3)

vitest.config.js (1)

1-41: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Compiled config output checked into repo.

Same generated-artifact concern: context snippet shows a vitest.config.ts with matching alias/test setup, confirming this .js is compiled output that duplicates the real source and will drift if only the .ts is edited going forward.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@vitest.config.js` around lines 1 - 41, This vitest.config.js appears to be
compiled/generated output duplicating the real vitest.config.ts source, so keep
only the source config in sync and remove this checked-in artifact or regenerate
it as part of the build. Update the actual config definition in the canonical
vitest.config.ts (including alias, test, coverage, and define settings) and
ensure the repo no longer relies on maintaining both files separately.

vitest.config.d.ts (1)

1-2: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Compiled config output checked into repo.

Same generated-artifact concern as vite.config.d.ts — this appears to be tsc output of vitest.config.ts.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@vitest.config.d.ts` around lines 1 - 2, This file is generated TypeScript
declaration output and should not be checked into the repo. Remove the compiled
artifact for vitest.config.d.ts and, if needed, update the build/repo
conventions so vitest.config.ts is the source of truth instead of committed tsc
output. Keep the cleanup aligned with the same generated-artifact handling used
for the related vite.config.d.ts file.

vite.config.js (1)

1-86: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Compiled config output checked into repo.

Same concern as vite.config.d.ts: this var/ES5-transpiled file is tsc-compiled output of a .ts source, not hand-written. Committing generated build artifacts alongside their .ts source (if it still exists) duplicates the source of truth and will silently go stale if the .ts file is edited without re-running the build.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@vite.config.js` around lines 1 - 86, The checked-in vite.config.js appears to
be generated output rather than the source of truth, duplicating the TypeScript
config and risking drift. Remove this compiled artifact from version control and
keep only the original source config (or ensure the build pipeline generates it
consistently); if the repo intentionally tracks generated files, document that
explicitly and align it with the corresponding vite.config.ts source.

🧹 Nitpick comments (4)

src/App.tsx (1)

196-209: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚖️ Poor tradeoff

Consider adding test coverage for the new LoadingScreen wiring.

LoadingScreen extraction changes a previously inline-tested code path; adding a focused test (render with initialLoadingCount === 1, verify Start button disabled/enabled states) would guard this refactor going forward.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/App.tsx` around lines 196 - 209, Add focused test coverage for the
`LoadingScreen` branch in `App` that is taken when `initialLoadingCount === 1`;
render `App` in that state and verify the `LoadingScreen` wiring, especially the
Start button disabled/enabled behavior as `loading`, `isDataLoadingComplete`,
and related props change. Use the `LoadingScreen` component and the
`handleStartClick`/`handleManualSpin` path to confirm the extracted UI still
behaves like the previous inline implementation.

src/utils/rawDataUtils.ts (1)

90-220: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Consider extracting the shared PR-resolution logic.

PullRequestEvent, PullRequestReviewEvent, and PullRequestReviewCommentEvent each repeat the same prNumber → htmlUrl → prTitle derivation. Since this PR is a consolidation effort, a small shared helper would remove the triplicated logic and keep the fallbacks in sync.

♻️ Sketch

const resolvePR = (event: GitHubEvent) => {
  const { payload, repo } = event;
  const pr = payload.pull_request!;
  const p = payload as { number?: number };
  let number = pr.number || p.number;
  if (!number) number = extractPRNumber(pr.html_url, (pr as { url?: string }).url);
  const htmlUrl = pr.html_url || (number
    ? `https://github.com/${repo.name}/pull/${number}`
    : `https://github.com/${repo.name}/pulls`);
  const title = (pr.title && pr.title !== 'undefined')
    ? pr.title
    : (number ? `Pull Request #${number}` : 'Pull Request');
  return { pr, number, htmlUrl, title };
};

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/utils/rawDataUtils.ts` around lines 90 - 220, The PR item builders in
PullRequestEvent, PullRequestReviewEvent, and PullRequestReviewCommentEvent
duplicate the same PR resolution flow for prNumber, htmlUrl, and prTitle.
Extract that shared logic into a small helper such as resolvePR in
rawDataUtils.ts, then update those handlers to use it so the fallback behavior
stays consistent and easier to maintain.

src/utils/viewFiltering.ts (1)

11-122: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Solid inlined implementation; qualifier-order handling is correct.

Verified the negated-before-positive extraction order (lines 90-96) correctly avoids \b word-boundary false matches on e.g. -label: being partially matched by \blabel: before it's stripped. The String.replace(m, ' ') loop (lines 47-49) also correctly handles duplicate qualifier values since matches are collected and replaced in left-to-right order.

One optional DRY improvement: the seven extractQualifier calls (lines 90-96) are structurally identical (regex + accumulator pairs) and could be driven by a small config array to reduce repetition and ease adding new qualifiers in the future.

♻️ Optional refactor to a config-driven loop

-  let cleanText = searchText;
-  cleanText = extractQualifier(cleanText, /-label:([^\s]+)/g, excludedLabels);
-  cleanText = extractQualifier(cleanText, /\blabel:([^\s]+)/g, includedLabels);
-  cleanText = extractQualifier(cleanText, /\buser:([^\s]+)/g, userFilters);
-  cleanText = extractQualifier(cleanText, /-repo:([^\s]+)/g, excludedRepos);
-  cleanText = extractQualifier(cleanText, /\brepo:([^\s]+)/g, includedRepos);
-  cleanText = extractQualifier(cleanText, /-org:([^\s]+)/g, excludedOrgs);
-  cleanText = extractQualifier(cleanText, /\borg:([^\s]+)/g, includedOrgs);
+  let cleanText = searchText;
+  const qualifierExtractions: [RegExp, string[]][] = [
+    [/-label:([^\s]+)/g, excludedLabels],
+    [/\blabel:([^\s]+)/g, includedLabels],
+    [/\buser:([^\s]+)/g, userFilters],
+    [/-repo:([^\s]+)/g, excludedRepos],
+    [/\brepo:([^\s]+)/g, includedRepos],
+    [/-org:([^\s]+)/g, excludedOrgs],
+    [/\borg:([^\s]+)/g, includedOrgs],
+  ];
+  for (const [regex, out] of qualifierExtractions) {
+    cleanText = extractQualifier(cleanText, regex, out);
+  }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/utils/viewFiltering.ts` around lines 11 - 122, Refactor parseSearchText
to reduce the repeated qualifier extraction calls by driving the seven
extractQualifier invocations from a small config array or similar mapping. Keep
the current negated-before-positive ordering and preserve the existing
accumulators in ParsedSearchText, but centralize the regex-to-target-array
wiring so adding new qualifiers later is easier.

vite.config.d.ts (1)

1-2: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Drop the generated Vite config artifacts. These files are emitted from vite.config.ts (tsconfig.node.json includes it) and aren’t referenced directly, so keeping vite.config.js, vite.config.d.ts, and tsconfig.node.tsbuildinfo checked in just adds drift risk.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@vite.config.d.ts` around lines 1 - 2, Remove the generated Vite config
artifacts from version control; the checked-in vite.config.d.ts is emitted by
vite.config.ts through tsconfig.node.json and is not meant to be maintained
manually. Delete the generated files alongside any other emitted config outputs
such as vite.config.js and tsconfig.node.tsbuildinfo so the repository only
keeps the source vite.config.ts and avoids drift.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/hooks/useGitHubDataFetching.ts`:
- Line 3: The `useGitHubDataFetching` module imports `EventsMetadata` as a value
import, which triggers a TS1484 error under `verbatimModuleSyntax`. Update the
import in `useGitHubDataFetching` to use a type-only import for
`EventsMetadata`, keeping the symbol reference intact while ensuring it is
erased from the emitted JavaScript.

In `@src/utils/rawDataUtils.ts`:
- Around line 352-367: The WatchEvent mapping is using the wrong default action,
which causes missing payload.action values to be treated as an unstarred event.
Update the WatchEvent handler in rawDataUtils so the fallback action is started,
and make sure the title/body logic in that mapper still uses the action value
consistently to render the starred variant when payload.action is absent.

In `@src/utils/README.md`:
- Around line 9-13: The README diagram block is missing a language identifier,
which causes markdownlint to flag it. Update the fenced block in the README so
the diagram uses an explicit language tag such as text, keeping the existing
content intact. Locate the markdown fence around the network → rawDataUtils →
viewFiltering / summaryGrouping → views diagram and add the language to that
fenced block only.

In `@tsconfig.node.tsbuildinfo`:
- Line 1: This change is a generated TypeScript incremental-build cache that
should not be versioned. Remove the committed tsbuildinfo artifact from the
repository, and update the project ignore rules to exclude all tsbuildinfo files
so future compiles do not reintroduce it. Locate and delete the incremental
cache entry named tsconfig.node.tsbuildinfo, and verify no other build-cache
artifacts are tracked.

In `@tsconfig.tsbuildinfo`:
- Line 1: Remove the generated tsbuildinfo artifact from version control and
keep it out of future commits by updating the repo’s ignore rules; the affected
file is the incremental build cache, so delete the tracked tsconfig.tsbuildinfo
entry and ensure the TypeScript build configuration continues to generate it
locally without committing it.

---

Duplicate comments:
In `@vite.config.js`:
- Around line 1-86: The checked-in vite.config.js appears to be generated output
rather than the source of truth, duplicating the TypeScript config and risking
drift. Remove this compiled artifact from version control and keep only the
original source config (or ensure the build pipeline generates it consistently);
if the repo intentionally tracks generated files, document that explicitly and
align it with the corresponding vite.config.ts source.

In `@vitest.config.d.ts`:
- Around line 1-2: This file is generated TypeScript declaration output and
should not be checked into the repo. Remove the compiled artifact for
vitest.config.d.ts and, if needed, update the build/repo conventions so
vitest.config.ts is the source of truth instead of committed tsc output. Keep
the cleanup aligned with the same generated-artifact handling used for the
related vite.config.d.ts file.

In `@vitest.config.js`:
- Around line 1-41: This vitest.config.js appears to be compiled/generated
output duplicating the real vitest.config.ts source, so keep only the source
config in sync and remove this checked-in artifact or regenerate it as part of
the build. Update the actual config definition in the canonical vitest.config.ts
(including alias, test, coverage, and define settings) and ensure the repo no
longer relies on maintaining both files separately.

---

Nitpick comments:
In `@src/App.tsx`:
- Around line 196-209: Add focused test coverage for the `LoadingScreen` branch
in `App` that is taken when `initialLoadingCount === 1`; render `App` in that
state and verify the `LoadingScreen` wiring, especially the Start button
disabled/enabled behavior as `loading`, `isDataLoadingComplete`, and related
props change. Use the `LoadingScreen` component and the
`handleStartClick`/`handleManualSpin` path to confirm the extracted UI still
behaves like the previous inline implementation.

In `@src/utils/rawDataUtils.ts`:
- Around line 90-220: The PR item builders in PullRequestEvent,
PullRequestReviewEvent, and PullRequestReviewCommentEvent duplicate the same PR
resolution flow for prNumber, htmlUrl, and prTitle. Extract that shared logic
into a small helper such as resolvePR in rawDataUtils.ts, then update those
handlers to use it so the fallback behavior stays consistent and easier to
maintain.

In `@src/utils/viewFiltering.ts`:
- Around line 11-122: Refactor parseSearchText to reduce the repeated qualifier
extraction calls by driving the seven extractQualifier invocations from a small
config array or similar mapping. Keep the current negated-before-positive
ordering and preserve the existing accumulators in ParsedSearchText, but
centralize the regex-to-target-array wiring so adding new qualifiers later is
easier.

In `@vite.config.d.ts`:
- Around line 1-2: Remove the generated Vite config artifacts from version
control; the checked-in vite.config.d.ts is emitted by vite.config.ts through
tsconfig.node.json and is not meant to be maintained manually. Delete the
generated files alongside any other emitted config outputs such as
vite.config.js and tsconfig.node.tsbuildinfo so the repository only keeps the
source vite.config.ts and avoids drift.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 513e291d-bbca-462a-8c77-f079930680ec

📥 Commits

Reviewing files that changed from the base of the PR and between 738a917 and 137b230.

📒 Files selected for processing (42)

• docs/BUTTON_WIDTH_FIX.md
• docs/CUSTOM_SECTIONS_FEATURE.md
• docs/GITHUB_API_FORMAT_CHANGE.md
• docs/PAGINATION_LIMIT_FIX.md
• docs/PR_ENRICHMENT_FEATURE.md
• docs/PWA_FEATURES.md
• docs/PWA_UPDATE_FEATURE.md
• docs/RACE_CONDITION_FIX.md
• docs/README_FILTERING_OPTIMIZATION.md
• docs/SEARCH_DEBOUNCING.md
• docs/SLOTMACHINE_OPTIMIZATION.md
• docs/UNDEFINED_TITLE_FIX.md
• src/App.tsx
• src/components/LoadingScreen.tsx
• src/hooks/useGitHubDataFetching.ts
• src/hooks/useGitHubDataProcessing.ts
• src/hooks/useGitHubFormState.ts
• src/hooks/useIndexedDBStorage.ts
• src/test/URLStateIntegration.test.tsx
• src/test/test-utils.tsx
• src/types.ts
• src/utils/README.md
• src/utils/__tests__/searchParsing.test.ts
• src/utils/filterUtils.test.ts
• src/utils/filterUtils.ts
• src/utils/githubSearch.test.ts
• src/utils/githubSearch.ts
• src/utils/indexedDB.ts
• src/utils/rawDataUtils.ts
• src/utils/resultsUtils.test.ts
• src/utils/resultsUtils.ts
• src/utils/summaryGrouping.ts
• src/utils/urlState.test.ts
• src/utils/urlState.ts
• src/utils/viewFiltering.ts
• src/views/Summary.tsx
• tsconfig.node.tsbuildinfo
• tsconfig.tsbuildinfo
• vite.config.d.ts
• vite.config.js
• vitest.config.d.ts
• vitest.config.js

💤 Files with no reviewable changes (7)

• src/utils/filterUtils.test.ts
• src/utils/filterUtils.ts
• src/utils/resultsUtils.ts
• src/utils/githubSearch.test.ts
• src/utils/resultsUtils.test.ts
• src/test/URLStateIntegration.test.tsx
• src/utils/githubSearch.ts

[coderabbitai]

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Don't commit generated .tsbuildinfo build cache.

This is a TypeScript incremental-build artifact regenerated on every compile. Committing it adds diff noise, becomes stale immediately, and risks merge conflicts. Add *.tsbuildinfo to .gitignore and remove this file from the repo.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tsconfig.node.tsbuildinfo` at line 1, This change is a generated TypeScript
incremental-build cache that should not be versioned. Remove the committed
tsbuildinfo artifact from the repository, and update the project ignore rules to
exclude all tsbuildinfo files so future compiles do not reintroduce it. Locate
and delete the incremental cache entry named tsconfig.node.tsbuildinfo, and
verify no other build-cache artifacts are tracked.

[Copilot]

Pull request overview

Refactor-focused architecture cleanup to remove duplicated/unused fetching/filtering code, tighten TypeScript types (notably around IndexedDB storage), and consolidate item classification logic to reduce drift across views and utilities.

Changes:

• Removed unused utility modules (githubSearch, resultsUtils, filterUtils) and moved the remaining “live” pieces (e.g., parseSearchText, ResultsFilter) into their actual consumers.
• Made IndexedDB storage APIs generic over stored item type to eliminate repeated casts and correct the Search-items store typing.
• Refactored event→item transformation into a dispatch-table style and extracted a full-screen LoadingScreen component from App.tsx.

Reviewed changes

Copilot reviewed 28 out of 42 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
vitest.config.js	Added JS Vitest config (appears to duplicate existing TS config).
vitest.config.d.ts	Added generated type stub for JS Vitest config.
vite.config.js	Added JS Vite config (appears to duplicate existing TS config).
vite.config.d.ts	Added generated type stub for JS Vite config.
tsconfig.tsbuildinfo	Added TS incremental build artifact to the repo.
src/views/Summary.tsx	Switched ad-hoc review detection to shared isReviewItem() helper.
src/utils/viewFiltering.ts	Inlined and documented parseSearchText + memoization; kept advanced filtering/sorting utilities.
src/utils/urlState.ts	Moved ResultsFilter + createDefaultFilter into URL state owner module.
src/utils/urlState.test.ts	Updated imports to use createDefaultFilter from urlState.
src/utils/summaryGrouping.ts	Added isReviewItem() and reused it for consistent review detection.
src/utils/resultsUtils.ts	Removed unused/stale duplicate results utilities module.
src/utils/README.md	Rewrote utils documentation to match current module responsibilities and data flow.
src/utils/rawDataUtils.ts	Refactored transformEventToItem into a handler dispatch table with shared base builders.
src/utils/indexedDB.ts	Introduced EventsMetadata and made stored dataset shape generic over item type.
src/utils/githubSearch.ts	Removed orphaned search/fetch stack (unused in production).
src/utils/githubSearch.test.ts	Removed tests for deleted orphaned githubSearch module.
src/utils/filterUtils.ts	Removed unused filter-counting utilities module.
src/utils/filterUtils.test.ts	Removed tests for deleted filterUtils module.
src/utils/tests/searchParsing.test.ts	Added unit tests covering parseSearchText behavior in its new home.
src/types.ts	Consolidated FormContextType as the single source of truth; removed UsernameCache type.
src/test/URLStateIntegration.test.tsx	Removed now-dead mock for deleted githubSearch module.
src/test/test-utils.tsx	Updated FormContext test mock to include searchText / setSearchText.
src/hooks/useIndexedDBStorage.ts	Made hook generic over stored item type and aligned metadata typing.
src/hooks/useGitHubFormState.ts	Removed debug logging during avatar cache revalidation.
src/hooks/useGitHubDataProcessing.ts	Correctly typed Search-items store as GitHubItem[]; removed casts; simplified enrichment progress callback.
src/hooks/useGitHubDataFetching.ts	Correctly typed Search-items store as GitHubItem[]; removed casts; clarified error propagation.
src/components/LoadingScreen.tsx	New extracted component for the initial full-screen loading/start experience.
src/App.tsx	Adopted typed FormContextType, generic IndexedDB hooks, and extracted LoadingScreen; removed casts.
docs/UNDEFINED_TITLE_FIX.md	Moved prior process/tech note into docs/.
docs/SLOTMACHINE_OPTIMIZATION.md	Moved prior process/tech note into docs/.
docs/SEARCH_DEBOUNCING.md	Moved prior process/tech note into docs/.
docs/README_FILTERING_OPTIMIZATION.md	Moved prior process/tech note into docs/.
docs/RACE_CONDITION_FIX.md	Moved prior process/tech note into docs/.
docs/PWA_UPDATE_FEATURE.md	Moved prior process/tech note into docs/.
docs/PWA_FEATURES.md	Moved prior process/tech note into docs/.
docs/PR_ENRICHMENT_FEATURE.md	Moved prior process/tech note into docs/.
docs/PAGINATION_LIMIT_FIX.md	Moved prior process/tech note into docs/.
docs/GITHUB_API_FORMAT_CHANGE.md	Moved prior process/tech note into docs/.
docs/CUSTOM_SECTIONS_FEATURE.md	Moved prior process/tech note into docs/.
docs/BUTTON_WIDTH_FIX.md	Moved prior process/tech note into docs/.

Comments suppressed due to low confidence (1)

src/utils/summaryGrouping.ts:56

• getEventType still calls item.title.startsWith(...) without guarding against missing titles. Elsewhere in this module you already use optional chaining on title, and the app has previously encountered items with missing titles (e.g., from corrupted/legacy cached Search API payloads). As written, a missing title will throw at runtime here.

Consider normalizing title once (e.g., const title = item.title ?? '') and using that for all prefix checks.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cloudflare-workers-and-pages]

Deploying git-vegas with    Cloudflare Pages

Latest commit:	424bd0a
Status:	✅  Deploy successful!
Preview URL:	https://ea639853.git-vegas.pages.dev
Branch Preview URL:	https://claude-code-architecture-rev.git-vegas.pages.dev

View logs