Skip to content

Fix pagination limit warning condition in fetchAllSearchItems #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kertal merged 2 commits into from
Jan 10, 2026
Merged

Fix pagination limit warning condition in fetchAllSearchItems #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
433d5cf
Initial plan
Copilot Jan 10, 2026
cad6b50
Fix pagination limit warning condition
Copilot Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/hooks/useGitHubDataFetching.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ export const useGitHubDataFetching = ({
let page = 1;
const perPage = GITHUB_API_PER_PAGE;
const maxPages = 10; // GitHub Search API allows up to 1000 results (10 pages * 100 per page)
let totalCount = 0;

const searchQuery = `(author:${username} OR assignee:${username}) AND updated:${startDate}..${endDate} AND (is:issue OR is:pr)`;

Expand All @@ -162,7 +163,7 @@ export const useGitHubDataFetching = ({
}

const searchData = await response.json();
const totalCount = searchData.total_count;
totalCount = searchData.total_count;
const items = searchData.items;

// Add original property to search items and ensure assignee data is preserved
Expand Down Expand Up @@ -191,11 +192,11 @@ export const useGitHubDataFetching = ({
}
}

// Log if we hit the pagination limit
if (page > maxPages) {
// Log if we hit the pagination limit but there are more items available
if (allItems.length < totalCount) {
console.warn(
`Reached GitHub Search API pagination limit (${maxPages} pages) for ${username}. ` +
`Returning ${allItems.length} items. GitHub API limits search results to 1000 items.`
`Returning ${allItems.length} items out of ${totalCount} total. GitHub API limits search results to 1000 items.`
);
}

Expand Down