Skip to content

Use Sessions for pick-up across repositories#1545

Merged
gjkim42 merged 1 commit into
mainfrom
agent/restrict-worker-sessions-to-pick-up
Jul 23, 2026
Merged

Use Sessions for pick-up across repositories#1545
gjkim42 merged 1 commit into
mainfrom
agent/restrict-worker-sessions-to-pick-up

Conversation

@kelos-bot

@kelos-bot kelos-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

🤖 Kelos Agent @gjkim42

What type of PR is this?

/kind bug

What this PR does / why we need it:

PR #1528 unintentionally broadened kelos-workers so every new issue or pull request conversation comment created a separate Session. SessionSpawner names Sessions by webhook delivery, so those comments did not continue the original Session; they created additional Sessions.

This change applies one explicit pickup mechanism across every configured repository: Kelos, Agora, and Kanon.

  • each repository has an issue pickup SessionSpawner and a PR pickup SessionSpawner
  • issue pickup requires an exact /kelos pick-up comment from gjkim42 on an open issue
  • PR pickup requires the same exact command in an open PR comment or submitted review
  • all six SessionSpawners use a 10 GiB PVC and only the base-agent AgentConfig
  • routine follow-ups continue through the persistent Session's web or terminal clients
  • ordinary comments, mismatched subjects, closed resources, and other authors do not spawn pickup Sessions

Which issue(s) this PR is related to:

N/A

Special notes for your reviewer:

Validation:

  • make verify
  • make test

Regression tests cover all six resources, including the resource kind, persistent workspace, exact AgentConfig references, issue and PR filters, repository-specific issue branches, PR branch rendering, and non-matching pickup cases.

Does this PR introduce a user-facing change?

NONE

@kelos-bot
kelos-bot Bot force-pushed the agent/restrict-worker-sessions-to-pick-up branch from 0ace094 to 4e9fed8 Compare July 23, 2026 21:42
@kelos-bot kelos-bot Bot changed the title Restrict worker Sessions to pick-up comments Use Sessions for issue and PR pick-up Jul 23, 2026
@kelos-bot
kelos-bot Bot force-pushed the agent/restrict-worker-sessions-to-pick-up branch from 4e9fed8 to 53f4e5a Compare July 23, 2026 21:54
@kelos-bot kelos-bot Bot changed the title Use Sessions for issue and PR pick-up Use Sessions for pick-up across repositories Jul 23, 2026
@gjkim42
gjkim42 marked this pull request as ready for review July 23, 2026 21:59
@kelos-bot
kelos-bot Bot force-pushed the agent/restrict-worker-sessions-to-pick-up branch from 53f4e5a to bdd703f Compare July 23, 2026 22:06
@gjkim42

gjkim42 commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

/kelos review

@kelos-bot

kelos-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Kelos Task Status

Task kelos-reviewer-issue-comment-90346e4127f1 has succeeded. ✅

@kelos-bot

kelos-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Kelos Reviewer Agent @gjkim42

Review Summary

Verdict: APPROVE
Overall correctness: patch is correct
Scope: Converts Kelos, Agora, and Kanon issue/PR pickup flows to persistent SessionSpawners with explicit maintainer commands and dev-deployment migration cleanup.

Findings Overview

Priority Count File:Line Summary
P0 0 none
P1 0 none
P2 1 self-development/README.md:94 Document TaskSpawner cleanup in every supported deployment path
P3 0 none

Findings

Documentation

  • [P2] self-development/README.md:94 — Changing a resource from TaskSpawner to SessionSpawner does not replace the old Kubernetes object, but the documented whole-directory and per-spawner deployment commands only run kubectl apply; an existing installation following those instructions will retain the replaced TaskSpawners alongside the new SessionSpawners, so one /kelos pick-up can launch both a Task and a Session against the same issue or PR. Mirror the workflow's kubectl delete taskspawner ... --ignore-not-found migration step in the Kelos, Agora, and Kanon README deployment paths for all six names.

Key takeaways

  • The filters, branch templates, persistent-volume settings, AgentConfig references, tests, workflow cleanup, and PR metadata otherwise align with the stated scope.
  • The Google-rubric review completed; the native Codex review path could not inspect the diff because its execution sandbox failed to initialize, so its empty result was not treated as an independent agreement signal.

@kelos-bot
kelos-bot Bot force-pushed the agent/restrict-worker-sessions-to-pick-up branch from bdd703f to 7bc2706 Compare July 23, 2026 22:14
@gjkim42
gjkim42 enabled auto-merge July 23, 2026 22:15
@gjkim42
gjkim42 added this pull request to the merge queue Jul 23, 2026
@kelos-bot
kelos-bot Bot removed this pull request from the merge queue due to a manual request Jul 23, 2026
@kelos-bot
kelos-bot Bot force-pushed the agent/restrict-worker-sessions-to-pick-up branch from 7bc2706 to b9c4233 Compare July 23, 2026 22:29
@gjkim42
gjkim42 enabled auto-merge July 23, 2026 22:29
@gjkim42
gjkim42 disabled auto-merge July 23, 2026 22:33
@kelos-bot
kelos-bot Bot force-pushed the agent/restrict-worker-sessions-to-pick-up branch from b9c4233 to 612303d Compare July 23, 2026 22:35
@gjkim42
gjkim42 merged commit e02539f into main Jul 23, 2026
18 of 19 checks passed
@gjkim42
gjkim42 deleted the agent/restrict-worker-sessions-to-pick-up branch July 23, 2026 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant