Skip to content

self-development: sweep sibling TaskSpawners when changing webhook filters #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kelos-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

self-development: sweep sibling TaskSpawners when changing webhook filters #1214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions self-development/agentconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,5 @@ spec:
- The `{{.Branch}}` template variable is empty for issue-only events; use `{{with index . "Branch"}}{{.}}{{else}}main{{end}}` when it may be empty
- The `issue_comment` webhook event fires for both issues and pull requests; design prompts to detect and handle both contexts
- Do not include manual PR branch checkout instructions in prompts — Kelos already checks out the PR branch automatically
- Sweep sibling spawners when changing webhook filters, triggers, labels, or shared prompt scaffolding: a filter tightening applied to one `self-development/*.yaml` (e.g. adding `commentOn`, narrowing `author`, scoping `bodyPattern`) almost always applies to every other spawner that listens to the same event family. Before opening the PR, `grep` the event name across `self-development/` and either update every match or document why a specific spawner is intentionally left alone.
- Before scoping a spawner to a single subject (`commentOn: Issue` vs `commentOn: PullRequest`), read its `promptTemplate` and confirm the prompt only ever handles that one subject. Dual-mode prompts that branch on `gh pr view` (or otherwise dispatch on Issue-vs-PR) need two filter entries — one per subject — not a single scoped filter that silently drops half the supported invocations.
2 changes: 2 additions & 0 deletions self-development/kelos-workers.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ spec:
- The `{{.Branch}}` template variable is empty for issue-only events; use `{{with index . "Branch"}}{{.}}{{else}}main{{end}}` when it may be empty
- The `issue_comment` webhook event fires for both issues and pull requests; design prompts to detect and handle both contexts
- Do not include manual PR branch checkout instructions in prompts — Kelos already checks out the PR branch automatically
- Sweep sibling spawners when changing webhook filters, triggers, labels, or shared prompt scaffolding: a filter tightening applied to one `self-development/*.yaml` (e.g. adding `commentOn`, narrowing `author`, scoping `bodyPattern`) almost always applies to every other spawner that listens to the same event family. Before opening the PR, `grep` the event name across `self-development/` and either update every match or document why a specific spawner is intentionally left alone.
- Before scoping a spawner to a single subject (`commentOn: Issue` vs `commentOn: PullRequest`), read its `promptTemplate` and confirm the prompt only ever handles that one subject. Dual-mode prompts that branch on `gh pr view` (or otherwise dispatch on Issue-vs-PR) need two filter entries — one per subject — not a single scoped filter that silently drops half the supported invocations.
---
apiVersion: kelos.dev/v1alpha1
kind: TaskSpawner
Expand Down
Loading