Windows 3.0.1: fix Enter on alert browser lists#104
Merged
Conversation
The alert-browser lists (region, event group, area) and the per-city alerts list were created without wx.WANTS_CHARS. Inside a wx.Dialog, a control does not receive the Enter (or Tab) key event without that style — the dialog consumes it for navigation — so the EVT_KEY_DOWN/Return handler never fired and Enter did nothing. (The search-results list only worked because Enter hits the default OK button; the alert-browser advance buttons aren't defaults.) Match the main city list's proven config: LB_SINGLE | WANTS_CHARS with an EVT_KEY_DOWN handler that advances on Return and re-implements Tab so keyboard focus can still leave the list. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enter did nothing on the Browse Weather Alerts region/group/area lists (and the per-city alerts list) because those wx.Dialog listboxes lacked wx.WANTS_CHARS, so the dialog ate the Enter key before the handler saw it. Match the working city-list config (WANTS_CHARS + Return/Tab handling). Ships as 3.0.1 so 3.0.0 users get it via auto-update.