Copy non-callable Optional defaults so mutable defaults aren't shared (fixes #352)#353
Open
vineethsaivs wants to merge 1 commit into
Open
Conversation
A non-callable default on an Optional (e.g. default=[] or default={})
was inserted into every validate() result by reference, so mutating one
result corrupted the default for all later validate() calls. Deep-copy
non-callable defaults so each validation gets its own object; callable
defaults already returned fresh objects.
Fixes keleshev#352.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #352.
A non-callable
defaulton anOptional(e.g.default=[]ordefault={}) was inserted into every validation result by reference, so the same object is shared across allvalidate()calls. Mutating one result then corrupts the default for every later call:Callable defaults (e.g.
default=list) already returned a fresh object each time, which is why they don't have this bug.Fix
Deep-copy non-callable defaults so each validation gets its own object:
Test
Added
test_dict_optional_mutable_default_not_shared: mutating one result's default must not leak into a latervalidate(). It fails onmaster([1]) and passes with this change. Fulltest_schema.pypasses (121 tests).