Stabilize Linux CI crash-path verification in test_stack_context - #8
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job 'linux'
Stabilize Linux CI crash-path verification in Jul 16, 2026
test_stack_context
keithpotz
approved these changes
Jul 16, 2026
keithpotz
marked this pull request as ready for review
July 16, 2026 16:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Linux Actions job failed because
test_stack_contextdid not consistently crash under Release optimization, sotest_stack_output/sentinel.txtwas never produced. This broke the workflow’s sentinel-based verification step.Root cause
tests/test_stack_context.cppused a compile-time null dereference pattern that can be optimized away in Release builds, allowing normal process exit.Change made
<cstdint>and introduced a volatile global crash address used bycrashSiteFunction().Impact
test_stack_contextnow deterministically exercises CrashCatch on Linux Release builds, restoring sentinel generation expected by CI.