fix(lint): make master lint-clean (zcash, hive, keepkey)#46
Merged
Conversation
`yarn lint` (eslint --cache --max-warnings=0 .) fails on a clean checkout across four files; the CI cache was intermittently masking hive.ts/keepkey.ts. - zcash.ts / zcash.test.ts: prettier formatting; convert 14 `console.log` debug traces to `console.info` (the no-console rule allows info/warn/error and these are intentional [zcash-pczt] diagnostics); remove an unused `hexToBytes` helper. - hive.ts / keepkey.ts: prettier formatting only (alignment/wrapping). No logic changes. zcash unit tests pass (4/4). Supersedes the stale #41.
2 tasks
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
yarn lint(eslint --cache --max-warnings=0 .) fails on a clean checkout of master — it's why every open hdwallet PR shows a redbuild (18)check. The--cachewas intermittently hiding part of it, but a fresh run fails across four files:packages/hdwallet-keepkey/src/zcash.tspackages/hdwallet-keepkey/src/zcash.test.tspackages/hdwallet-keepkey/src/hive.tspackages/hdwallet-keepkey/src/keepkey.tsChanges (no logic changes)
console.logdebug traces toconsole.info(the repo'sno-consolerule allowsinfo/warn/error, and these are intentional[zcash-pczt]diagnostics — kept, not removed, mirroring theeslint-disable … intentional diagnosticspattern already inethereum.ts); remove an unusedhexToByteshelper in the test.Verification
yarn lint→ clean (Done, 0 problems).zcash.test.ts→ 4/4 pass (mock-based, no device).Why
Supersedes the stale #41 (a month old,
CONFLICTING, and only covered a fraction of the now-158 errors). Getting master lint-clean lets every other hdwallet PR (#40, #42, #45) show a true CI status instead of inheriting this red.