Skip to content

fix(keepkey-webusb): clearHalt the IN pipe on a stalled read, not OUT #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BitHighlander merged 2 commits into from
Jun 7, 2026
Merged

fix(keepkey-webusb): clearHalt the IN pipe on a stalled read, not OUT #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cda0ae8
fix(keepkey-webusb): clearHalt the IN pipe on a stalled read, not OUT
BitHighlander Jun 7, 2026
758ec47
Merge branch 'master' into fix/webusb-clearhalt-endpoint
BitHighlander Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/hdwallet-keepkey-nodewebusb/src/transport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,11 @@ export class TransportDelegate implements keepkey.TransportDelegate {
async readChunk(debugLink?: boolean): Promise<Uint8Array> {
const result = await this.usbDevice.transferIn(debugLink ? 2 : 1, keepkey.SEGMENT_SIZE + 1);

if (result.status === "stall" && result.data !== undefined) {
await this.usbDevice.clearHalt("out", debugLink ? 2 : 1);
if (result.status === "stall") {
// Reset the halt on the IN pipe we just read (not OUT), then surface a
// retryable error -- a stalled transfer's buffer is not a valid packet.
await this.usbDevice.clearHalt("in", debugLink ? 2 : 1);
throw new Error("bad read");
} else if (result.status !== "ok" || result.data === undefined) {
throw new Error("bad read");
}
Expand Down
5 changes: 4 additions & 1 deletion packages/hdwallet-keepkey-webusb/src/transport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ export class TransportDelegate implements keepkey.TransportDelegate {
const { status, data } = await this.usbDevice.transferIn(debugLink ? 2 : 1, keepkey.SEGMENT_SIZE + 1);

if (status === "stall") {
await this.usbDevice.clearHalt("out", debugLink ? 2 : 1);
// Reset the halt on the IN pipe we just read (not OUT), then surface a
// retryable error -- a stalled transfer's buffer is not a valid packet.
await this.usbDevice.clearHalt("in", debugLink ? 2 : 1);
throw new Error("bad read");
}

if (data === undefined) throw new Error("bad read");
Expand Down
Loading