fix(prometheus): add Thanos Querier compatibility mode#6482
Open
ykd007 wants to merge 2 commits into
Open
Conversation
…tions, fingerprints, pending alerts
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Connecting Keep's Prometheus provider to a Thanos Querier fails with:
This happens because Thanos Querier does not implement
/api/v1/alerts(that endpoint only exists on Prometheus's built-in rules evaluator / Alertmanager). Keep's connectivity check and alert polling both hit that endpoint unconditionally.Closes #6474
Solution
Adds a
thanos_compatible: boolflag (defaultFalse) toPrometheusProviderAuthConfig. When enabled:/api/v1/rules?type=alertinstead of/api/v1/alerts/api/v1/rules?type=alertwhich Thanos supports and which returns full alert data including annotations, state (firing/pending),activeAt, and labelsthanos_compatible: false(default) are unchangedTesting
Set
thanos_compatible: truein provider auth config when connecting to a Thanos Querier URL.