CLI advanced encryption settings PoC#13284
Draft
jaceee-gh wants to merge 2 commits intokeepassxreboot:developfrom
Draft
CLI advanced encryption settings PoC#13284jaceee-gh wants to merge 2 commits intokeepassxreboot:developfrom
jaceee-gh wants to merge 2 commits intokeepassxreboot:developfrom
Conversation
jaceee-gh
force-pushed
the
feature/advanced-encryption-in-cli
branch
from
1bc53a6 to
8e09c47
Compare
* Ported UI encryption settings inline Things to resolve: * Viability of approach * Code dupe * Whether or not string conversion functions are acceptable * Current & remaining tests * Documentation?
jaceee-gh
force-pushed
the
feature/advanced-encryption-in-cli
branch
5 times, most recently
from
6e21b16 to
63bd171
Compare
jaceee-gh
force-pushed
the
feature/advanced-encryption-in-cli
branch
from
63bd171 to
52a65b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/gui/dbsettings/DatabaseSettingsWidgetEncryption.cpp)Things to resolve:
Screenshots
Testing strategy
Type of change