Skip to content

Fix missing -D in cmake opts setting#13252

Open
droidmonkey wants to merge 1 commit intodevelopfrom
fix/release-tool-cmakeopts
Open

Fix missing -D in cmake opts setting#13252
droidmonkey wants to merge 1 commit intodevelopfrom
fix/release-tool-cmakeopts

Conversation

@droidmonkey
Copy link
Copy Markdown
Member

  • Bug found using copilot review

Type of change

  • ✅ Bug fix (non-breaking change that fixes an issue)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Windows release packaging configuration by ensuring the timestamp URL CMake option is passed as a proper -D definition, so CMake actually receives and applies the WITH_XC_CODESIGN_TIMESTAMP_URL setting during signed builds.

Changes:

  • Corrected a missing -D prefix for the WITH_XC_CODESIGN_TIMESTAMP_URL CMake cache variable in the Windows build path.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.45%. Comparing base (7c7ca45) to head (4e202c8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13252      +/-   ##
===========================================
- Coverage    64.45%   64.45%   -0.00%     
===========================================
  Files          378      378              
  Lines        39797    39797              
===========================================
- Hits         25649    25648       -1     
- Misses       14148    14149       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

* Bug found using copilot review
@droidmonkey droidmonkey force-pushed the fix/release-tool-cmakeopts branch from 4d934e7 to 4e202c8 Compare May 5, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants