Skip to content

feat(frontend): create comment feature on video page#29

Merged
keanu-a merged 8 commits into
mainfrom
keanucaloua/kyy-50-add-create-comment-feature-on-video-page
Jul 1, 2026
Merged

feat(frontend): create comment feature on video page#29
keanu-a merged 8 commits into
mainfrom
keanucaloua/kyy-50-add-create-comment-feature-on-video-page

Conversation

@keanu-a

@keanu-a keanu-a commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Description

Builds on timestamp-marker PR to make comments postable. Uses can now comment from two areas:

  • The video player that anchors current playback time
  • Comment section for general comments with no timestamp
    Only timestamped comments render as markers on the video time range bar. general comments live in the comment section only

Changes

  • Post comment from video player -> anchors timestamp -> creates marker on timeline
  • Post comment from comment section -> no timestamp
  • Comments are ordered from newest-first
  • Multi-line comments are supported
  • Made timestampSeconds nullable on the backend and changed for typings/usage on frontend
  • Created usePostComment hook so reused logic for video player comment input and comment section input
  • Extracted CommentInput from comment section to handle its own state and not inflate VideoPageClient

Deferred

  • Login prompt when commenting
  • Sorting comments
  • Comment likes and replies
  • Real profile pictures

@keanu-a keanu-a merged commit 253d996 into main Jul 1, 2026
3 checks passed
@keanu-a keanu-a deleted the keanucaloua/kyy-50-add-create-comment-feature-on-video-page branch July 1, 2026 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant